🐞 when migration task isn't completed but the migration is successful, mark task as successful #1324
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: #1305
In case a VM migration task is not marked as finished (i.e. task.phase is undefined), but its pipeline step is marked as completed successfully then mark the task in UI as completed successfully as well.
This will solve cases as mentioned in #1305 in which the
DiskTransferV2v
orDiskTransfer
tasks aren't completed although the migration is successful.This fix was done for all migration VM types (not necessarily limited for vSphere or OVA VMs).
Before
After
Note that the Task modal popup will still show the real info and will reflect that the task was not really finished: