🐞 Handle fetching from inventory for users without a full namespaces access role #1307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaacov
requested changes
Aug 18, 2024
packages/forklift-console-plugin/src/modules/Providers/views/list/ProvidersListPage.tsx
Outdated
Show resolved
Hide resolved
yaacov
reviewed
Aug 18, 2024
packages/forklift-console-plugin/src/modules/Providers/hooks/useProvidersInventoryList.ts
Outdated
Show resolved
Hide resolved
yaacov
reviewed
Aug 18, 2024
packages/forklift-console-plugin/src/modules/Providers/hooks/useProvidersInventoryList.ts
Outdated
Show resolved
Hide resolved
yaacov
reviewed
Aug 18, 2024
packages/forklift-console-plugin/src/modules/Providers/hooks/useProvidersInventoryList.ts
Outdated
Show resolved
Hide resolved
sgratch
force-pushed
the
handle-non-all-ns-users-fetching-from-inventory
branch
3 times, most recently
from
431ff47 to
9fdf819
Compare
|
I addressed all of the above. Screenshots for example:
|
yaacov
reviewed
Aug 21, 2024
packages/forklift-console-plugin/src/modules/Providers/hooks/useProvidersInventoryList.ts
Outdated
Show resolved
Hide resolved
yaacov
reviewed
Aug 21, 2024
packages/forklift-console-plugin/src/modules/Providers/views/list/ProvidersListPage.tsx
Outdated
Show resolved
Hide resolved
yaacov
reviewed
Aug 21, 2024
packages/forklift-console-plugin/src/modules/Providers/views/list/ProvidersListPage.tsx
Outdated
Show resolved
Hide resolved
yaacov
reviewed
Aug 21, 2024
...rklift-console-plugin/src/modules/Providers/views/list/components/NamespaceNotAccessible.tsx
Outdated
Show resolved
Hide resolved
sgratch
force-pushed
the
handle-non-all-ns-users-fetching-from-inventory
branch
2 times, most recently
from
c7fd8a0 to
42c88ec
Compare
yaacov
reviewed
Aug 22, 2024
There was a problem hiding this comment.
this changes where moved to #1310
yaacov
reviewed
Aug 22, 2024
packages/forklift-console-plugin/src/modules/Providers/hooks/useProvidersInventoryList.ts
Outdated
Show resolved
Hide resolved
yaacov
reviewed
Aug 22, 2024
packages/forklift-console-plugin/src/modules/Providers/hooks/useProvidersInventoryList.ts
Outdated
Show resolved
Hide resolved
yaacov
reviewed
Aug 22, 2024
packages/forklift-console-plugin/src/modules/Providers/hooks/useProvidersInventoryList.ts
Outdated
Show resolved
Hide resolved
sgratch
force-pushed
the
handle-non-all-ns-users-fetching-from-inventory
branch
from
42c88ec to
61d9e44
Compare
yaacov
reviewed
Aug 29, 2024
packages/forklift-console-plugin/src/modules/Providers/hooks/useProvidersInventoryList.ts
Outdated
Show resolved
Hide resolved
sgratch
force-pushed
the
handle-non-all-ns-users-fetching-from-inventory
branch
4 times, most recently
from
4506a7b to
8bb7e83
Compare
sgratch
force-pushed
the
handle-non-all-ns-users-fetching-from-inventory
branch
from
8bb7e83 to
00551d2
Compare
…to list all namespaces Reference: kubev2v#1293 Handle providers fetching from inventory for users with limited namespace roles, who can only list their namespaces content and don't have get permissions to all namespaces. Before the fix, when those users tried to fetch providers inventory data, regarldess to current namespace, the "inventory server is not reachable" error was always displayed. After this fix, those users will not fetch all namepsaces but only ones which they allow to list. So the fetching should now succeed and no error should be displayed. Signed-off-by: Sharon Gratch <[email protected]>
sgratch
force-pushed
the
handle-non-all-ns-users-fetching-from-inventory
branch
from
00551d2 to
cc5f48d
Compare
|
|
cypress test fail addressed by: #1317 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: #1293
Handle providers fetching from inventory for logged users with limited namespace roles (not kubeadmin), who can only list their namespaces content and don't have get permissions to all namespaces.
Before the fix, when such a user tried to fetch providers inventory data (i.e. display the providers list), regardless to current namespace, the "
inventory server is not reachable" error was always displayed and inventory data fetching failed.After this fix, such a user that tries to fetch inventory data under his permitted namespace(s), will succeed to do that and no error is displayed.
Before:
After