oVirt - filter VMs by available dynamic enum list of hosts #1298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaacov
reviewed
Jul 31, 2024
| return { | ||
| type: 'host', | ||
| primary: true, | ||
| placeholderLabel: t('Host'), | ||
| dynamicFilter: (items: { hostName: string }[]) => ({ | ||
| values: [ | ||
| ...Array.from(new Set(items.map((item) => item.hostName))) // at this point the list contains unique strings that can be used as ID | ||
| .map((label: string): EnumValue => ({ id: label, label })), | ||
| //.map((label: string): EnumValue => ({ id: label, label })), |
There was a problem hiding this comment.
forgot to remove the commented code ?
yaacov
reviewed
Jul 31, 2024
Comment on lines
16
to
19
| .map( | ||
| (label: string): EnumValue => | ||
| label !== '' ? { id: label, label } : { id: label, label: 'Undefined' }, | ||
| ), |
There was a problem hiding this comment.
Suggested change
| .map( | |
| (label: string): EnumValue => | |
| label !== '' ? { id: label, label } : { id: label, label: 'Undefined' }, | |
| ), | |
| .map(labelToFilterItem), |
/* ...
*/
const labelToFilterItem = (label: string): EnumValue => label !== '' ? { id: label, label } : { id: label, label: 'Undefined' }
Reference: kubev2v#1275 This includes the following changes for the oVirt provider VMs list only: 1. Set the 'Host' filter to be a primary filter. 2. Display a dynamic list of hosts that the VMs run on as an enum filter to select. 3. All VMs that are not assigned to any host, will be filtered out by the "Undefined" option. 4. Enable selecting any number of hosts from the enum filter list. If none, all VMs are filtered. 5. Enable to type-ahead input for displaying a subset of the enum filter list of hosts. Signed-off-by: Sharon Gratch <[email protected]>
sgratch
force-pushed
the
ovirt-filter-vms-by-available-dynamic-enum-host-list
branch
from
025fac6 to
092aa5e
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: #1275
This includes the following changes for the oVirt provider VMs list only:
Before:
After: