🐾 Update to PF5 - part II - onClick event handler #1208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaacov
reviewed
Jun 10, 2024
...-console-plugin/src/modules/NetworkMaps/views/details/components/MapsSection/MapsSection.tsx
Show resolved
Hide resolved
yaacov
reviewed
Jun 10, 2024
packages/common/src/components/ActionServiceDropdown/ActionServiceDropdown.tsx
Outdated
Show resolved
Hide resolved
yaacov
reviewed
Jun 10, 2024
packages/common/src/components/ActionServiceDropdown/ActionServiceDropdown.tsx
Outdated
Show resolved
Hide resolved
yaacov
added
the
enhancement
yaacov
changed the title
sgratch
force-pushed
the
onclick-event-handler-naming-typed
branch
from
071e6ea to
fdaa1e7
Compare
|
yaacov
reviewed
Jun 17, 2024
...onsole-plugin/src/modules/Overview/views/overview/tabs/Metrics/cards/MigrationsChartCard.tsx
Outdated
Show resolved
Hide resolved
sgratch
force-pushed
the
onclick-event-handler-naming-typed
branch
from
fdaa1e7 to
00c76ce
Compare
yaacov
reviewed
Jun 18, 2024
...onsole-plugin/src/modules/Overview/views/overview/tabs/Metrics/cards/MigrationsChartCard.tsx
Outdated
Show resolved
Hide resolved
sgratch
force-pushed
the
onclick-event-handler-naming-typed
branch
from
00c76ce to
dc9ee17
Compare
Reference: kubev2v#1098 Seems like onClick event handler parameters was changed in PF5 for few of the components by enforcing the event handler as the first parameter (E.g. https://www.patternfly.org/components/chip/#chip while in our code we are not passing the event https://github.com/kubev2v/forklift-console-plugin/blob/686daff412d61c5e84c14f7b87fe2867038fc14b/packages/forklift-console-plugin/src/modules/Plans/views/create/components/ChipsToolbarProviders.tsx#L40). For avoiding uncaught migration errors, this PR named and typed all callback appearances, when possible Signed-off-by: Sharon Gratch <[email protected]>
sgratch
force-pushed
the
onclick-event-handler-naming-typed
branch
from
dc9ee17 to
5c6e273
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: #1098
Include 2 changes:
onClickevent handler parameters were not changed in PF5.But to be on the safe side and avoid uncaught PF 4 -> PF 5 migration errors, this PR typed (i.e. (add type to function
signature) all
onClickcallback appearances which include the event parameter.onClickcallback appearances (when possible).