Rephrase migration phase label for failed VMs under uncompleted Plan

Reference: #1277 When the plan status is not set yet as failed but at least one VM under that plan was failed to migrated already, change the phase status from "vm fail" to "Some VMs Failed" to be more clear. Signed-off-by: Sharon Gratch <[email protected]>
kubev2v · Sep 5, 2024 · f9dea41 · f9dea41
1 parent 7e85021
commit f9dea41
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/packages/forklift-console-plugin/locales/en/plugin__forklift-console-plugin.json b/packages/forklift-console-plugin/locales/en/plugin__forklift-console-plugin.json
@@ -428,6 +428,7 @@
   "Skip certificate validation": "Skip certificate validation",
   "Skip VMware Virtual Disk Development Kit (VDDK) SDK acceleration, migration may be slow.": "Skip VMware Virtual Disk Development Kit (VDDK) SDK acceleration, migration may be slow.",
   "Snapshot polling interval (seconds)": "Snapshot polling interval (seconds)",
+  "Some VMs Failed": "Some VMs Failed",
   "Something is wrong, the data was not loaded due to an error, please try to reload the page.": "Something is wrong, the data was not loaded due to an error, please try to reload the page.",
   "Something is wrong, the secret was not loaded, please try to reload the page.": "Something is wrong, the secret was not loaded, please try to reload the page.",
   "source": "source",
@@ -527,7 +528,6 @@
   "Virtual machines": "Virtual machines",
   "Virtual Machines": "Virtual Machines",
   "Virtual machines:": "Virtual machines:",
-  "VM Failed": "VM Failed",
   "VM(s) with more than one interface mapped to Pod Networking were detected.": "VM(s) with more than one interface mapped to Pod Networking were detected.",
   "VM(s) with multiple NICs on the same network were detected.": "VM(s) with multiple NICs on the same network were detected.",
   "VM(s) with NICs that are not linked with a NIC profile were detected.": "VM(s) with NICs that are not linked with a NIC profile were detected.",

diff --git a/packages/forklift-console-plugin/src/modules/Plans/utils/helpers/getPhaseLabel.ts b/packages/forklift-console-plugin/src/modules/Plans/utils/helpers/getPhaseLabel.ts
@@ -23,8 +23,8 @@ const phaseLabels: Record<PlanPhase, string> = {
   Error: 'Error',
   // t('Warning')
   Warning: 'Warning',
-  // t('VM Failed')
-  vmError: 'VM Failed',
+  // t('Some VMs Failed')
+  vmError: 'Some VMs Failed',
   // t('Unknown')
   Unknown: 'Unknown',
 };