Merge pull request #1179 from yaacov/hide-conditions-in-plan-migratin…

…g-vm-extended-view 🧼 Hide empty conditions sections
kubev2v · May 29, 2024 · ef4218f · ef4218f
2 parents d4c7a97 + aaba117
commit ef4218f
Showing 1 changed file with 32 additions and 28 deletions.
diff --git a/...lans/views/details/tabs/VirtualMachines/Migration/MigrationVirtualMachinesRowExtended.tsx b/...lans/views/details/tabs/VirtualMachines/Migration/MigrationVirtualMachinesRowExtended.tsx
@@ -156,34 +156,38 @@ export const MigrationVirtualMachinesRowExtended: React.FC<RowProps<VMData>> = (
         </>
       )}
 
-      <SectionHeading
-        text={'Conditions'}
-        className="forklift-page-plan-details-vm-status__section-header"
-      />
-      <TableComposable aria-label="Expandable table" variant="compact">
-        <Thead>
-          <Tr>
-            <Th width={10}>{t('Type')}</Th>
-            <Th width={10}>{t('Status')}</Th>
-            <Th width={20}>{t('Updated')}</Th>
-            <Th width={10}>{t('Reason')}</Th>
-            <Th> {t('Message')}</Th>
-          </Tr>
-        </Thead>
-        <Tbody>
-          {(conditions || []).map((condition) => (
-            <Tr key={condition.type}>
-              <Td>{condition.type}</Td>
-              <Td>{getStatusLabel(condition.status)}</Td>
-              <Td>
-                <Timestamp timestamp={condition.lastTransitionTime} />
-              </Td>
-              <Td>{condition.reason}</Td>
-              <Td modifier="truncate">{condition?.message || '-'}</Td>
-            </Tr>
-          ))}
-        </Tbody>
-      </TableComposable>
+      {(conditions || []).length > 0 && (
+        <>
+          <SectionHeading
+            text={'Conditions'}
+            className="forklift-page-plan-details-vm-status__section-header"
+          />
+          <TableComposable aria-label="Expandable table" variant="compact">
+            <Thead>
+              <Tr>
+                <Th width={10}>{t('Type')}</Th>
+                <Th width={10}>{t('Status')}</Th>
+                <Th width={20}>{t('Updated')}</Th>
+                <Th width={10}>{t('Reason')}</Th>
+                <Th> {t('Message')}</Th>
+              </Tr>
+            </Thead>
+            <Tbody>
+              {(conditions || []).map((condition) => (
+                <Tr key={condition.type}>
+                  <Td>{condition.type}</Td>
+                  <Td>{getStatusLabel(condition.status)}</Td>
+                  <Td>
+                    <Timestamp timestamp={condition.lastTransitionTime} />
+                  </Td>
+                  <Td>{condition.reason}</Td>
+                  <Td modifier="truncate">{condition?.message || '-'}</Td>
+                </Tr>
+              ))}
+            </Tbody>
+          </TableComposable>
+        </>
+      )}
 
       <SectionHeading
         text={'Pipeline'}