Merge pull request #1139 from sgratch/rephrase-preserveStaticIPs-text…

…-label 🧼 ephrase the text label for the preserveStaticIPs flag
kubev2v · May 6, 2024 · 6c017da · 6c017da
2 parents cc02eac + 9284dc7
commit 6c017da
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 5 deletions.
diff --git a/packages/forklift-console-plugin/locales/en/plugin__forklift-console-plugin.json b/packages/forklift-console-plugin/locales/en/plugin__forklift-console-plugin.json
@@ -112,6 +112,7 @@
   "Details": "Details",
   "Determines the frequency with which the system checks the status of snapshot creation or removal during oVirt warm migration. The default value is 10 seconds.": "Determines the frequency with which the system checks the status of snapshot creation or removal during oVirt warm migration. The default value is 10 seconds.",
   "Disk Transfer": "Disk Transfer",
+  "Do not try to preserve the static IPs of VMs with Windows guest operating system from vSphere.": "Do not try to preserve the static IPs of VMs with Windows guest operating system from vSphere.",
   "Domain": "Domain",
   "Domain name": "Domain name",
   "Drag and drop a file or upload one": "Drag and drop a file or upload one",
@@ -336,7 +337,7 @@
   "Preserve CPU model": "Preserve CPU model",
   "Preserve static IPs": "Preserve static IPs",
   "Preserve the CPU model and flags the VM runs with in its oVirt cluster.": "Preserve the CPU model and flags the VM runs with in its oVirt cluster.",
-  "Preserve the static IPs that the VM runs with in vSphere provider's environment.": "Preserve the static IPs that the VM runs with in vSphere provider's environment.",
+  "Preserve the static IPs of VMs with Windows guest operating system from vSphere.": "Preserve the static IPs of VMs with Windows guest operating system from vSphere.",
   "Product": "Product",
   "Project": "Project",
   "Project ID": "Project ID",

diff --git a/...lans/views/details/components/SettingsSection/components/PreserveStaticIPsDetailsItem.tsx b/...lans/views/details/components/SettingsSection/components/PreserveStaticIPsDetailsItem.tsx
@@ -18,7 +18,7 @@ export const PreserveStaticIPsDetailsItem: React.FC<PlanDetailsItemProps> = ({
   const { showModal } = useModal();
 
   const defaultHelpContent = t(
-    `Preserve the static IPs that the VM runs with in vSphere provider's environment.`,
+    `Preserve the static IPs of VMs with Windows guest operating system from vSphere.`,
   );
 
   const trueLabel = (

diff --git a/...components/SettingsSection/modals/EditPlanPreserveStaticIPs/EditPlanPreserveStaticIPs.tsx b/...components/SettingsSection/modals/EditPlanPreserveStaticIPs/EditPlanPreserveStaticIPs.tsx
@@ -38,6 +38,8 @@ interface SwitchRendererProps {
 }
 
 const PreserveStaticIPsInputFactory: () => ModalInputComponentType = () => {
+  const { t } = useForkliftTranslation();
+
   const SwitchRenderer: React.FC<SwitchRendererProps> = ({ value, onChange }) => {
     const onChangeInternal = (v) => {
       onChange(v ? 'true' : 'false');
@@ -46,8 +48,12 @@ const PreserveStaticIPsInputFactory: () => ModalInputComponentType = () => {
     return (
       <Switch
         id="simple-switch"
-        label="Preserve the static IPs that the VM runs with in vSphere provider's environment."
-        labelOff="Do not try to preserve the static IPs that the VM runs with in vSphere provider's environment."
+        label={t(
+          'Preserve the static IPs of VMs with Windows guest operating system from vSphere.',
+        )}
+        labelOff={t(
+          'Do not try to preserve the static IPs of VMs with Windows guest operating system from vSphere.',
+        )}
         isChecked={value === 'true'}
         onChange={onChangeInternal}
       />
@@ -68,7 +74,7 @@ const EditPlanPreserveStaticIPs_: React.FC<EditPlanPreserveStaticIPsProps> = (pr
       label={props?.label || t('Whether to preserve the static IPs')}
       model={PlanModel}
       onConfirmHook={onConfirm}
-      body={t(`Preserve the static IPs that the VM runs with in vSphere provider's environment.`)}
+      body={t(`Preserve the static IPs of VMs with Windows guest operating system from vSphere.`)}
       InputComponent={PreserveStaticIPsInputFactory()}
     />
   );