Allow editing plan settings only for specific plan's statuses

Reference: https://issues.redhat.com/browse/MTV-1713 Enable editing of plan details -> settings fields only for the following plan statuses: Unknown', 'Canceled', 'Error', 'Failed', 'vmError', 'Warning', 'Ready and disable the edit option for all others. Signed-off-by: Sharon Gratch <[email protected]>
kubev2v · Nov 27, 2024 · 40e7bb5 · 40e7bb5
1 parent 84a9896
commit 40e7bb5
Show file tree

Hide file tree

Showing 8 changed files with 32 additions and 1 deletion.
diff --git a/packages/forklift-console-plugin/src/modules/Plans/utils/helpers/getPlanPhase.ts b/packages/forklift-console-plugin/src/modules/Plans/utils/helpers/getPlanPhase.ts
@@ -103,5 +103,19 @@ export const isPlanSucceeded = (plan: V1beta1Plan) => {
   return conditions?.includes('Succeeded');
 };
 
+export const isPlanEditable = (plan: V1beta1Plan) => {
+  const planStatus = getPlanPhase({ obj: plan });
+
+  return (
+    planStatus === 'Unknown' ||
+    planStatus === 'Canceled' ||
+    planStatus === 'Error' ||
+    planStatus === 'Failed' ||
+    planStatus === 'vmError' ||
+    planStatus === 'Warning' ||
+    planStatus === 'Ready'
+  );
+};
+
 const getConditions = (obj: V1beta1Plan) =>
   obj?.status?.conditions?.filter((c) => c.status === 'True').map((c) => c.type);
diff --git a/...iews/details/components/SettingsSection/components/PreserveClusterCpuModelDetailsItem.tsx b/...iews/details/components/SettingsSection/components/PreserveClusterCpuModelDetailsItem.tsx
@@ -1,4 +1,5 @@
 import React from 'react';
+import { isPlanEditable } from 'src/modules/Plans/utils';
 import { useModal } from 'src/modules/Providers/modals';
 import { DetailsItem } from 'src/modules/Providers/utils';
 import { useForkliftTranslation } from 'src/utils/i18n';
@@ -40,6 +41,7 @@ export const PreserveClusterCpuModelDetailsItem: React.FC<PlanDetailsItemProps>
       crumbs={['spec', 'preserveClusterCpuModel']}
       onEdit={
         canPatch &&
+        isPlanEditable(resource) &&
         (() =>
           showModal(
             <EditPlanPreserveClusterCpuModel

diff --git a/...lans/views/details/components/SettingsSection/components/PreserveStaticIPsDetailsItem.tsx b/...lans/views/details/components/SettingsSection/components/PreserveStaticIPsDetailsItem.tsx
@@ -1,4 +1,5 @@
 import React from 'react';
+import { isPlanEditable } from 'src/modules/Plans/utils';
 import { useModal } from 'src/modules/Providers/modals';
 import { DetailsItem } from 'src/modules/Providers/utils';
 import { useForkliftTranslation } from 'src/utils/i18n';
@@ -40,6 +41,7 @@ export const PreserveStaticIPsDetailsItem: React.FC<PlanDetailsItemProps> = ({
       crumbs={['spec', 'preserveStaticIPs']}
       onEdit={
         canPatch &&
+        isPlanEditable(resource) &&
         (() =>
           showModal(
             <EditPlanPreserveStaticIPs

diff --git a/...modules/Plans/views/details/components/SettingsSection/components/RootDiskDetailsItem.tsx b/...modules/Plans/views/details/components/SettingsSection/components/RootDiskDetailsItem.tsx
@@ -1,4 +1,5 @@
 import React from 'react';
+import { isPlanEditable } from 'src/modules/Plans/utils';
 import { useModal } from 'src/modules/Providers/modals';
 import { DetailsItem } from 'src/modules/Providers/utils';
 import { useForkliftTranslation } from 'src/utils/i18n';
@@ -30,7 +31,11 @@ export const RootDiskDetailsItem: React.FC<PlanDetailsItemProps> = ({
       helpContent={helpContent ?? defaultHelpContent}
       moreInfoLink={VIRT_V2V_HELP_LINK}
       crumbs={['spec', 'vms', 'rootDisk']}
-      onEdit={canPatch && (() => showModal(<EditRootDisk resource={resource} />))}
+      onEdit={
+        canPatch &&
+        isPlanEditable(resource) &&
+        (() => showModal(<EditRootDisk resource={resource} />))
+      }
     />
   );
 };

diff --git a/...s/details/components/SettingsSection/components/SetLUKSEncryptionPasswordsDetailsItem.tsx b/...s/details/components/SettingsSection/components/SetLUKSEncryptionPasswordsDetailsItem.tsx
@@ -1,4 +1,5 @@
 import React from 'react';
+import { isPlanEditable } from 'src/modules/Plans/utils';
 import { useModal } from 'src/modules/Providers/modals';
 import { DetailsItem } from 'src/modules/Providers/utils';
 import { useForkliftTranslation } from 'src/utils/i18n';
@@ -43,6 +44,7 @@ export const SetLUKSEncryptionPasswordsDetailsItem: React.FC<PlanDetailsItemProp
       crumbs={['spec', 'vms', 'luks']}
       onEdit={
         canPatch &&
+        isPlanEditable(resource) &&
         (() =>
           showModal(
             <EditLUKSEncryptionPasswords

diff --git a/.../Plans/views/details/components/SettingsSection/components/TargetNamespaceDetailsItem.tsx b/.../Plans/views/details/components/SettingsSection/components/TargetNamespaceDetailsItem.tsx
@@ -1,4 +1,5 @@
 import React from 'react';
+import { isPlanEditable } from 'src/modules/Plans/utils';
 import { useModal } from 'src/modules/Providers/modals';
 import { DetailsItem } from 'src/modules/Providers/utils';
 import { useForkliftTranslation } from 'src/utils/i18n';
@@ -28,6 +29,7 @@ export const TargetNamespaceDetailsItem: React.FC<PlanDetailsItemProps> = ({
       crumbs={['spec', 'targetNamespace ']}
       onEdit={
         canPatch &&
+        isPlanEditable(resource) &&
         (() =>
           showModal(
             <EditPlanTargetNamespace

diff --git a/.../Plans/views/details/components/SettingsSection/components/TransferNetworkDetailsItem.tsx b/.../Plans/views/details/components/SettingsSection/components/TransferNetworkDetailsItem.tsx
@@ -1,4 +1,5 @@
 import React from 'react';
+import { isPlanEditable } from 'src/modules/Plans/utils';
 import { useModal } from 'src/modules/Providers/modals';
 import { DetailsItem } from 'src/modules/Providers/utils';
 import { useForkliftTranslation } from 'src/utils/i18n';
@@ -37,6 +38,7 @@ export const TransferNetworkDetailsItem: React.FC<PlanDetailsItemProps> = ({
       crumbs={['spec', 'transferNetwork ']}
       onEdit={
         canPatch &&
+        isPlanEditable(resource) &&
         (() =>
           showModal(
             <EditPlanTransferNetwork

diff --git a/...src/modules/Plans/views/details/components/SettingsSection/components/WarmDetailsItem.tsx b/...src/modules/Plans/views/details/components/SettingsSection/components/WarmDetailsItem.tsx
@@ -1,4 +1,5 @@
 import React from 'react';
+import { isPlanEditable } from 'src/modules/Plans/utils';
 import { useModal } from 'src/modules/Providers/modals';
 import { DetailsItem } from 'src/modules/Providers/utils';
 import { useForkliftTranslation } from 'src/utils/i18n';
@@ -38,6 +39,7 @@ export const WarmDetailsItem: React.FC<PlanDetailsItemProps> = ({
       crumbs={['spec', 'warm ']}
       onEdit={
         canPatch &&
+        isPlanEditable(resource) &&
         (() =>
           showModal(<EditPlanWarm resource={resource} destinationProvider={destinationProvider} />))
       }