Skip to content

Commit

Permalink
Merge pull request #1390 from sgratch/replace-vddk-help-msg-example-w…
Browse files Browse the repository at this point in the history
…ith-format-follow-up

For VDDK help text - replace the example with a format - step 2
  • Loading branch information
yaacov authored Nov 24, 2024
2 parents 7036ecd + 6de5690 commit 27ef3b4
Show file tree
Hide file tree
Showing 8 changed files with 12 additions and 14 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -433,7 +433,7 @@
"Show archived": "Show archived",
"Show the welcome card": "Show the welcome card",
"Skip certificate validation": "Skip certificate validation",
"Skip VMware Virtual Disk Development Kit (VDDK) SDK acceleration, migration may be slow.": "Skip VMware Virtual Disk Development Kit (VDDK) SDK acceleration, migration may be slow.",
"Skip VMware Virtual Disk Development Kit (VDDK) SDK acceleration (migration might be slow).": "Skip VMware Virtual Disk Development Kit (VDDK) SDK acceleration (migration might be slow).",
"Snapshot polling interval (seconds)": "Snapshot polling interval (seconds)",
"Some VMs Failed": "Some VMs Failed",
"Something is wrong, the data was not loaded due to an error, please try to reload the page.": "Something is wrong, the data was not loaded due to an error, please try to reload the page.",
Expand Down Expand Up @@ -520,7 +520,7 @@
"URL of the API endpoint of the Red Hat Virtualization Manager (RHVM) on which the source VM is mounted. Ensure that the URL includes the path leading to the RHVM API server, usually /ovirt-engine/api. For example, https://rhv-host-example.com/ovirt-engine/api.": "URL of the API endpoint of the Red Hat Virtualization Manager (RHVM) on which the source VM is mounted. Ensure that the URL includes the path leading to the RHVM API server, usually /ovirt-engine/api. For example, https://rhv-host-example.com/ovirt-engine/api.",
"URL of the NFS file share that serves the OVA., for example, 10.10.0.10:/ova": "URL of the NFS file share that serves the OVA., for example, 10.10.0.10:/ova",
"URL of the Openshift Virtualization API endpoint.": "URL of the Openshift Virtualization API endpoint.",
"URL of the Openshift Virtualization API endpoint. Empty may be used for the host provider.": "URL of the Openshift Virtualization API endpoint. Empty may be used for the host provider.",
"URL of the Openshift Virtualization API endpoint. Empty might be used for the host provider.": "URL of the Openshift Virtualization API endpoint. Empty might be used for the host provider.",
"URL of the providers API endpoint. The URL must be a valid endpoint for the provider type, see\n the documentation for each provider type to learn more about the URL format.": "URL of the providers API endpoint. The URL must be a valid endpoint for the provider type, see\n the documentation for each provider type to learn more about the URL format.",
"User ID": "User ID",
"Username": "Username",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ export const EditProviderVDDKImage: React.FC<EditProviderVDDKImageProps> = (prop
<Checkbox
className="forklift-section-provider-edit-vddk-checkbox"
label={t(
'Skip VMware Virtual Disk Development Kit (VDDK) SDK acceleration, migration may be slow.',
'Skip VMware Virtual Disk Development Kit (VDDK) SDK acceleration (migration might be slow).',
)}
isChecked={isEmptyImage}
onChange={(e, v) => onChange(v, e)}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export const ItemIsOwnedAlert: React.FC<ItemIsOwnedAlertProps> = ({ owner, names
// https://kubernetes.io/docs/concepts/overview/working-with-objects/owners-dependents/
namespace={namespace}
/>{' '}
and any modifications may be overwritten. Edit the managing resource to preserve changes.
and any modifications might be overwritten. Edit the managing resource to preserve changes.
</ForkliftTrans>
</Alert>
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,9 @@ export const VDDKHelperText: React.FC = () => (
<br />

<p>
It is strongly recommended to create a VDDK init image to accelerate migrations. For more
information, see{' '}
To accelerate migrations, we recommend to create a VDDK init image. Learn more about{' '}
<ExternalLink isInline href={CREATE_VDDK_HELP_LINK}>
Creating VDDK image
Creating a VDDK image
</ExternalLink>
.
</p>
Expand All @@ -31,10 +30,9 @@ export const VDDKHelperText: React.FC = () => (
export const VDDKHelperTextShort: React.FC = () => (
<ForkliftTrans>
<p>
It is strongly recommended to create a VDDK init image to accelerate migrations. For more
information, see{' '}
To accelerate migrations, we recommend to create a VDDK init image. Learn more about{' '}
<ExternalLink isInline href={CREATE_VDDK_HELP_LINK}>
Creating VDDK image
Creating a VDDK image
</ExternalLink>
.
</p>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ export const EsxiProviderCreateForm: React.FC<EsxiProviderCreateFormProps> = ({
<Checkbox
className="forklift-section-provider-edit-vddk-checkbox"
label={t(
'Skip VMware Virtual Disk Development Kit (VDDK) SDK acceleration, migration may be slow.',
'Skip VMware Virtual Disk Development Kit (VDDK) SDK acceleration (migration might be slow).',
)}
isChecked={emptyVddkInitImage === 'yes'}
onChange={(e, v) => onChangEmptyVddk(v, e)}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ export const VCenterProviderCreateForm: React.FC<VCenterProviderCreateFormProps>
<Checkbox
className="forklift-section-provider-edit-vddk-checkbox"
label={t(
'Skip VMware Virtual Disk Development Kit (VDDK) SDK acceleration, migration may be slow.',
'Skip VMware Virtual Disk Development Kit (VDDK) SDK acceleration (migration might be slow).',
)}
isChecked={emptyVddkInitImage === 'yes'}
onChange={(e, v) => onChangEmptyVddk(v, e)}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ export const OpenshiftDetailsSection: React.FC<DetailsSectionProps> = ({ data })
resource={provider}
canPatch={permissions.canPatch}
helpContent={t(
'URL of the Openshift Virtualization API endpoint. Empty may be used for the host provider.',
'URL of the Openshift Virtualization API endpoint. Empty might be used for the host provider.',
)}
/>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export const VDDKDetailsItem: React.FC<ProviderDetailsItemProps> = ({
valid container image path in the format of{' '}
<strong>registry_route_or_server_path/vddk:&#8249;tag&#8250;</strong>.<br />
<br />
It is strongly recommended to specify a VDDK init image to accelerate migrations.
To accelerate migrations, we recommend to specify a VDDK init image.
</ForkliftTrans>
);

Expand Down

0 comments on commit 27ef3b4

Please sign in to comment.