Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace glide to go mod #46

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

replace glide to go mod #46

wants to merge 7 commits into from

Conversation

weiliang-ms
Copy link

  1. Replace glide to go mod.
  2. Bump golang from 1.11 to 1.19

@weiliang-ms
bump golang from 1.11 to 1.19
6c0b3ee 
change glide to go mod
@weiliang-ms
bump golang from 1.11 to 1.19
5bfc018 
change glide to go mod
@ks-ci-bot ks-ci-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 13, 2022
@weiliang-ms
Copy link
Author

/assign @LinuxSuRen

@weiliang-ms
add go.mod go.sum into Dockerfile
8b82016
@weiliang-ms
change build content:
fb2492f 
github.com/kubesphere/s2irun/cmd -> s2irun/cmd
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: weiliang-ms
To complete the pull request process, please ask for approval from linuxsuren after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LinuxSuRen
LinuxSuRen reviewed Dec 13, 2022
View reviewed changes
Copy link
Member

@LinuxSuRen LinuxSuRen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can test the GitHub actions locally with https://github.com/nektos/act

@weiliang-ms
Copy link
Author

You can test the GitHub actions locally with https://github.com/nektos/act

OK. I'll try.

@weiliang-ms
Copy link
Author

You can test the GitHub actions locally with https://github.com/nektos/act

OK. I'll try.

When I simulated the build using act, the build image looked successful now.

image

LinuxSuRen
LinuxSuRen reviewed Dec 14, 2022
View reviewed changes
Copy link
Member

@LinuxSuRen LinuxSuRen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LinuxSuRen
Copy link
Member

/cc @chilianyi

@ks-ci-bot ks-ci-bot requested a review from chilianyi December 14, 2022 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinuxSuRen LinuxSuRen LinuxSuRen left review comments

@chilianyi chilianyi Awaiting requested review from chilianyi

Assignees

@LinuxSuRen LinuxSuRen

Labels
size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@weiliang-ms @ks-ci-bot @LinuxSuRen