fix: handle null rendering in BaseDataTable cell (#321)

* fix: handle null rendering in BaseDataTable cell Signed-off-by: ya zhou <[email protected]> * refactor: remove unused styled-components import in DataTable Signed-off-by: ya zhou <[email protected]> * ci: update version Signed-off-by: ya zhou <[email protected]> --------- Signed-off-by: ya zhou <[email protected]>
kubesphere · Dec 10, 2024 · fc5f10b · fc5f10b
1 parent 27c7d12
commit fc5f10b
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 2 deletions.
diff --git a/.changeset/wise-garlics-hang.md b/.changeset/wise-garlics-hang.md
@@ -0,0 +1,13 @@
+---
+'@kubed/code-editor': patch
+'@kubed/diff-viewer': patch
+'@kubed/components': patch
+'@kubed/log-viewer': patch
+'@kubed/charts': patch
+'@kubed/hooks': patch
+'@kubed/icons': patch
+'@kubed/tests': patch
+'kubed-documents': patch
+---
+
+fix: handle null rendering in BaseDataTable cell
diff --git a/packages/components/src/Table/DataTable/BaseTable.tsx b/packages/components/src/Table/DataTable/BaseTable.tsx
@@ -65,7 +65,7 @@ export function BaseDataTable<T>({ table }: BaseDataTableProps<T>) {
                     {...(getTdProps && getTdProps(table, cell.getContext()))}
                     {...(cell.column.columnDef.meta?.td ?? {})}
                   >
-                    {flexRender(cell.column.columnDef.cell, cell.getContext())}
+                    {flexRender(cell.column.columnDef.cell, cell.getContext()) ?? null}
                   </BaseTable.TableCell>
                 ))}
               </BaseTable.TableRow>

diff --git a/packages/components/src/Table/DataTable/Table.tsx b/packages/components/src/Table/DataTable/Table.tsx
@@ -1,7 +1,6 @@
 import type { Header, Row, RowData, Table, TableState } from '@tanstack/react-table';
 import cx from 'classnames';
 import * as React from 'react';
-import styled from 'styled-components';
 import * as BaseTable from '../BaseTable';
 import { BaseDataTable } from './BaseTable';
 import { Pagination, TableFooter } from './Pagination';