Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: format files #4364

Merged
merged 2 commits into from
Dec 19, 2024
Merged

style: format files #4364

merged 2 commits into from
Dec 19, 2024

Conversation

donniean
Copy link
Contributor

What type of PR is this?

What this PR does / why we need it

Which issue(s) this PR fixes

Links #

Special notes for reviewers

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: donniean

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 19, 2024
@donniean
Copy link
Contributor Author

/cherry-pick release-4.1

@ks-ci-bot
Copy link
Collaborator

@donniean: once the present PR merges, I will cherry-pick it on top of release-4.1 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@donniean donniean added the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2024
@donniean
Copy link
Contributor Author

/hold

@donniean
style: format files
91ea4c8 
Signed-off-by: donniean <[email protected]>
@ks-ci-bot ks-ci-bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2024
@ks-ci-bot
Copy link
Collaborator

New changes are detected. LGTM label has been removed.

@donniean donniean changed the title style: format server/sample/bookinfo.yaml style: format files Dec 19, 2024
@ks-ci-bot ks-ci-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 19, 2024
@donniean donniean added the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2024
@donniean
Copy link
Contributor Author

/unhold

@donniean
Copy link
Contributor Author

/test pull-console-build

@ks-ci-bot ks-ci-bot merged commit 69224e8 into kubesphere:master Dec 19, 2024
5 checks passed
@ks-ci-bot
Copy link
Collaborator

@donniean: new pull request created: #4365

In response to this:

/cherry-pick release-4.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ks-ci-bot ks-ci-bot mentioned this pull request Dec 19, 2024
Merged
@donniean donniean deleted the master branch December 19, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@donniean @ks-ci-bot