Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add version in image #4359

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Conversation

redscholar
Copy link
Contributor

@redscholar redscholar commented Dec 12, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it

test results:
image

Which issue(s) this PR fixes

Links # https://github.com/kubesphere/project/issues/4523

Special notes for reviewers


Does this PR introduced a user-facing change?

add version in image

Additional documentation, usage docs, etc


@ks-ci-bot ks-ci-bot added release-note kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 12, 2024
Signed-off-by: joyceliu <[email protected]>
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: donniean, redscholar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 16, 2024
@donniean
Copy link
Contributor

/cherry-pick release-4.1

@ks-ci-bot
Copy link
Collaborator

@donniean: once the present PR merges, I will cherry-pick it on top of release-4.1 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@donniean
Copy link
Contributor

/cc @wansir

@ks-ci-bot ks-ci-bot requested a review from wansir December 16, 2024 05:40
@wansir
Copy link
Member

wansir commented Dec 18, 2024

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2024
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: d6ce3d617e0cac3269afa5c0ea2039a4ff6f7809

hack/version.sh Outdated Show resolved Hide resolved
hack/version.sh Outdated Show resolved Hide resolved
@ks-ci-bot ks-ci-bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2024
Signed-off-by: joyceliu <[email protected]>
@wansir
Copy link
Member

wansir commented Dec 18, 2024

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2024
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 6afa3d18dd14ce2b81dcf47b08399246febef3e7

@ks-ci-bot ks-ci-bot merged commit 06d64f6 into kubesphere:master Dec 18, 2024
5 checks passed
@ks-ci-bot
Copy link
Collaborator

@donniean: new pull request created: #4363

In response to this:

/cherry-pick release-4.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants