Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust app-releases button permission #4342

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lingbohome
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it

optimize app-releases detail page mange permission

Which issue(s) this PR fixes

Fixes # 6273

Special notes for reviewers


Does this PR introduced a user-facing change?

adjust app-releases button permission

Additional documentation, usage docs, etc


@ks-ci-bot ks-ci-bot added release-note kind/bug Categorizes issue or PR as related to a bug. labels Nov 13, 2024
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lingbohome
To complete the pull request process, please assign zheng1 after the PR has been reviewed.
You can assign the PR to them by writing /assign @zheng1 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot
Copy link
Collaborator

Hi @lingbohome. Thanks for your PR.

I'm waiting for a kubesphere member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ks-ci-bot ks-ci-bot added needs-ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 13, 2024
@donniean
Copy link
Contributor

/cc @Leioy

@ks-ci-bot ks-ci-bot requested a review from Leioy November 13, 2024 08:54
Copy link
Contributor

@ROOMrepair ROOMrepair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@@ -210,7 +210,7 @@ function DetailInfo(): JSX.Element {
cardProps={{
name: getDisplayName(detail),
desc: detail?.description,
authKey: 'applications',
authKey: 'app-releases',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lingbohome Hello lingbohome! I have tried your solution, and seems it still works without modifying authkey, when a user is set to project-admin or workspace-admin. or I maybe overlook some cases?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason why I adjusted it to app-releases is that I saw that the authKey of other pages of this module was configured as app-releases, and the authKey of this module in the front-end configuration file was also configured as app-releases, and the back-end roletemplate, the front-end permissions of this module, were also configured as app-releases.
So I feel that it should be consistent with it?

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 12, 2024
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 0a7d412dc3213737850b1065ba08ec275fac1802

@ks-ci-bot
Copy link
Collaborator

@lingbohome: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-console-build 2058f09 link /test pull-console-build

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test release-note size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants