-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adjust app-releases button permission #4342
base: master
Are you sure you want to change the base?
adjust app-releases button permission #4342
Conversation
Signed-off-by: lingbo <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lingbohome The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @lingbohome. Thanks for your PR. I'm waiting for a kubesphere member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @Leioy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@@ -210,7 +210,7 @@ function DetailInfo(): JSX.Element { | |||
cardProps={{ | |||
name: getDisplayName(detail), | |||
desc: detail?.description, | |||
authKey: 'applications', | |||
authKey: 'app-releases', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lingbohome Hello lingbohome! I have tried your solution, and seems it still works without modifying authkey, when a user is set to project-admin or workspace-admin. or I maybe overlook some cases?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason why I adjusted it to app-releases is that I saw that the authKey of other pages of this module was configured as app-releases, and the authKey of this module in the front-end configuration file was also configured as app-releases, and the back-end roletemplate, the front-end permissions of this module, were also configured as app-releases.
So I feel that it should be consistent with it?
LGTM label has been added. Git tree hash: 0a7d412dc3213737850b1065ba08ec275fac1802
|
@lingbohome: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What type of PR is this?
/kind bug
What this PR does / why we need it
optimize app-releases detail page mange permission
Which issue(s) this PR fixes
Fixes # 6273
Special notes for reviewers
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc