Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove useless API #4311

Merged
merged 2 commits into from
Sep 25, 2024
Merged

chore: remove useless API #4311

merged 2 commits into from
Sep 25, 2024

Conversation

donniean
Copy link
Contributor

@donniean donniean commented Sep 25, 2024

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

The endpoints /kapis/config.kubesphere.io/v1alpha2/configs/gpu/kinds and /apis/installer.kubesphere.io/v1alpha1/clusterconfigurations?name=ks-installer have been deprecated in version 4.x, so the related requests have been removed.

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:


@ks-ci-bot ks-ci-bot added release-note-none kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 25, 2024
@donniean
Copy link
Contributor Author

/cc @wansir

@ks-ci-bot ks-ci-bot requested a review from wansir September 25, 2024 02:43
@donniean
Copy link
Contributor Author

/cc @yazhouio

@ks-ci-bot ks-ci-bot requested a review from yazhouio September 25, 2024 02:43
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: donniean, yazhouio

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yazhouio
Copy link
Member

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2024
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 5f231b5d863194886df65bfafe738904ea61d8ac

@ks-ci-bot ks-ci-bot merged commit 473cc71 into kubesphere:master Sep 25, 2024
5 checks passed
@donniean donniean deleted the master branch September 25, 2024 02:53
Leioy pushed a commit to Leioy/console that referenced this pull request Sep 25, 2024
* chore: remove api /configs/gpu/kinds from server



* chore: remove api /clusterconfigurations?name=ks-installer from server



---------

Signed-off-by: donniean <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants