Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix the tag version of image after the tag is selected #4228

Merged
merged 3 commits into from
Oct 26, 2023

Conversation

harrisonliu5
Copy link
Contributor

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #kubesphere/kubesphere#5851

Special notes for reviewers:

Does this PR introduced a user-facing change?

fix: fix the tag version of image after the tag is selected 

Additional documentation, usage docs, etc.:


* fix: fix the image selected

Signed-off-by: harrisonliu5 <[email protected]>

* fix: fix the image not fetch when the secret is harbor

Signed-off-by: harrisonliu5 <[email protected]>

* fix: add the fetch abort to get dockhub

Signed-off-by: harrisonliu5 <[email protected]>

---------

Signed-off-by: harrisonliu5 <[email protected]>
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harrisonliu5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 24, 2023
@harrisonliu5 harrisonliu5 added the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2023
@ks-ci-bot ks-ci-bot merged commit 8f171db into kubesphere:master Oct 26, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants