Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [devops 3.4.1] fix devops pipeline run log (#1772) #4218

Merged
merged 1 commit into from
Oct 23, 2023
Merged

fix: [devops 3.4.1] fix devops pipeline run log (#1772) #4218

merged 1 commit into from
Oct 23, 2023

Conversation

yazhouio
Copy link
Member

  • fix: fix devops pipeline run log

  • fix: update pipeline run log refresh icon

  • fix: fix devops pipeline run log refresh action

  • fix: fix devops history card name


What type of PR is this?

/kind bug

What this PR does / why we need it:

Limit the size of online run log to 20MB, with each request size being 100KB.
Change the download method to download the log from the server.
Fix other bugs in devops.

Which issue(s) this PR fixes:

Fixes #kubesphere/ks-devops#986
Fixes #kubesphere/ks-devops#978
Fixes #kubesphere/ks-devops#752
Fixes #kubesphere/ks-devops#993
Fixes #https://github.com/kubesphere/issues/issues/1989

Special notes for reviewers:

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:


* fix: fix devops pipeline run log

Signed-off-by: yazhou <[email protected]>

* fix: update pipeline run log refresh icon

Signed-off-by: yazhou <[email protected]>

* fix: fix devops pipeline run log refresh action

Signed-off-by: yazhou <[email protected]>

* fix: fix devops history card name

Signed-off-by: yazhou <[email protected]>

---------

Signed-off-by: yazhou <[email protected]>
@ks-ci-bot ks-ci-bot added release-note-none kind/bug Categorizes issue or PR as related to a bug. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 20, 2023
@yazhouio yazhouio changed the title fix: [devops 3.5] fix devops pipeline run log (#1772) fix: [devops 3.4.1] fix devops pipeline run log (#1772) Oct 20, 2023
@harrisonliu5
Copy link
Contributor

/lgtm
/approve

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2023
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 6fceb7f4529cda185124b69fd1c46bad70c2c8b1

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harrisonliu5, yazhouio

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2023
@ks-ci-bot ks-ci-bot merged commit af7067d into kubesphere:master Oct 23, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants