Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed:The 0 in the front of pvc autosizer input can not be deleted #4174 #4202

Closed
wants to merge 1 commit into from

Conversation

studyingwang23
Copy link
Contributor

@studyingwang23 studyingwang23 commented Sep 25, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #4174

Special notes for reviewers:

In addition, add two variables to the file in this path。
path:`\node_modules\@kube-design\components\esm\components\Slider\Slider.js`
![image](https://github.com/kubesphere/console/assets/109194125/f455ae10-aee2-4d21-92b0-462125716e87)

The code position in the file under this path:
code:
      var _this$props8 = this.props,
          className = _this$props8.className,
          style = _this$props8.style,
          railStyle = _this$props8.railStyle,
          trackStyle = _this$props8.trackStyle,
          range = _this$props8.range,
          unit = _this$props8.unit,
          withInput = _this$props8.withInput,
          min = _this$props8.min,
          max = _this$props8.max,
          innerRef = _this$props8.innerRef; // 新增变量

React.createElement(Input, {
        type: "number",
        value: value[1],
        onChange: this.handleInputChange,
        max: max,
        min: min,
        innerRef: innerRef  // 新增变量
      })

Does this PR introduced a user-facing change?


Additional documentation, usage docs, etc.:


@ks-ci-bot
Copy link
Collaborator

@studyingwang23: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ks-ci-bot ks-ci-bot added the kind/bug Categorizes issue or PR as related to a bug. label Sep 25, 2023
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: studyingwang23
To complete the pull request process, please assign zheng1 after the PR has been reviewed.
You can assign the PR to them by writing /assign @zheng1 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot
Copy link
Collaborator

Hi @studyingwang23. Thanks for your PR.

I'm waiting for a kubesphere member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ks-ci-bot ks-ci-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 25, 2023
@studyingwang23
Copy link
Contributor Author

/assign @zheng1

@harrisonliu5
Copy link
Contributor

sorry, we will open a new PR to solve this issue, thank you for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/release-note-label-needed kind/bug Categorizes issue or PR as related to a bug. needs-ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The "0" in the front of pvc autosizer input can not be deleted..
4 participants