Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: metric guide for ks #289

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,61 @@
# Why we need to add metrics to kubesphere

Metrics can provide insight into the behavior and health of our system. They represent the raw material used by monitoring system to build a holistic view of kubesphere, automate responses to changes, and alert human beings when required.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should add :


# How to add new metric

* 1. [Define the metric](#Define)
* 2. [Register the metric](#Register)
* 3. [Export the metric](#Export)


## 1. <a name='Define'></a>Define the metric
Define the metric in the file `metric.go` of you package or somewhere else.

```go
package application

import (
compbasemetrics "k8s.io/component-base/metrics"
"kubesphere.io/kubesphere/pkg/utils/metrics"
)

var (
// add a counter metric
appTemplateCreationCounter = compbasemetrics.NewCounterVec(
&compbasemetrics.CounterOpts{
Name: "application_template_creation", // metric name
Help: "Counter of application template creation broken out for each workspace, name and create state", // metric help info
StabilityLevel: compbasemetrics.ALPHA, //represents the API guarantees for a given defined metric
},
//we want to export the namespace, name and current state of the appTemplate
[]string{"workspace", "name", "state"}, // the labels of the metric
)
)

```

## 2. <a name='Register'></a>Register the metric
```go
package application
import (
"kubesphere.io/kubesphere/pkg/utils/metrics"
)

func init(){
Register()
}

func Register() {
metrics.MustRegister(appTemplateCreationCounter)
}
```

## 3. <a name='Export'></a>Export the metric
```go
package application
func (c *appTemplateOperator) CreateApp(request *CreateAppRequest) {
// export app template create metric with label values
appTemplateCreationCounter.WithLabelValues("workspace", "Name", "failed").Inc()
}
```