sse in api - logs piped from pod #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LiveLogs.mp4 |
nicufk
reviewed
Nov 11, 2021
| @@ -157,6 +158,14 @@ func (c ProxyScriptsAPI) ExecuteScript(id, namespace, executionName string, exec | |||
| return c.getExecutionFromResponse(resp) | |||
| } | |||
|
|
|||
| func (c ProxyScriptsAPI) Logs(id string) (logs chan output.Output, err error) { | |||
There was a problem hiding this comment.
Will this be implemented in the future? should we add a TODO tag or something like that.
jasmingacic
approved these changes
Nov 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request description
SSE (Server Sent Events) endpoint for API
No OpenAPI spec yet as of : OAI/OpenAPI-Specification#396 wechaty/openapi#20
Works for now on direct API client (from local machine) proxied need to be implemented
Checklist (choose whats happened)
Breaking changes
Changes
Fixes