Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to slack upload file v2 api #1468

Closed
wants to merge 2 commits into from
Closed

Switch to slack upload file v2 api #1468

wants to merge 2 commits into from

Conversation

vaijab
Copy link
Contributor

@vaijab vaijab commented Jul 4, 2024

Description

Changes proposed in this pull request:

  • Switch to slack upload file v2 api

Testing

Related issue(s)

@vaijab vaijab added enhancement New feature or request slack labels Jul 4, 2024
@vaijab vaijab requested a review from PrasadG193 as a code owner July 4, 2024 10:05
@vaijab vaijab requested review from a team and madebyrogal July 4, 2024 10:05
@vaijab vaijab force-pushed the uploadv2 branch 5 times, most recently from ccfe27f to 63e079c Compare July 5, 2024 12:03
@madebyrogal
Copy link
Contributor

@vaijab how can I test this?

@vaijab vaijab marked this pull request as draft July 9, 2024 06:37
@vaijab vaijab force-pushed the uploadv2 branch 3 times, most recently from 7b8e01a to a060e03 Compare July 10, 2024 09:29
@TonyLovesDevOps
Copy link

Subscribed to this PR... this is required as new apps won't work since slack deprecated files.upload for new apps.

I added botkube to a third cluster and it received an error like this when trying to return content:

{"bot":"SocketSlack","commGroup":"default-group","error":"while sending message: while uploading file: method_deprecated","level":"error","msg":"Failed to handle Socket Slack message","time":"2024-08-23T20:44:06Z"}

The other two clusters are still working since I created their corresponding Slack apps before the May 8, 2024 deadline. In either case, this method will stop working for all apps as of March 11, 2025.

@mszostok
Copy link
Collaborator

Will be fixed in #1480

@mszostok mszostok closed this Nov 10, 2024
@mszostok mszostok deleted the uploadv2 branch November 10, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request slack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants