Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Slack bot user name from CI by default #1213

Merged
merged 3 commits into from
Aug 25, 2023
Merged

Remove Slack bot user name from CI by default #1213

merged 3 commits into from
Aug 25, 2023

Conversation

huseyinbabal
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Remove slack bot username override

Testing

Related issue(s)

@huseyinbabal huseyinbabal requested review from a team and josefkarasek August 25, 2023 11:29
@huseyinbabal huseyinbabal changed the title remove slack bot user by default Remove Slack bot user name from CI by default Aug 25, 2023
@huseyinbabal huseyinbabal added the ci Related to CI pipelines label Aug 25, 2023
@huseyinbabal huseyinbabal added the bug Something isn't working label Aug 25, 2023
@huseyinbabal
Copy link
Contributor Author

Newly added cfg fields have env variables in workflow files, but it will be reflected on next pr

josefkarasek
josefkarasek approved these changes Aug 25, 2023
View reviewed changes
Copy link

@josefkarasek josefkarasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@huseyinbabal huseyinbabal merged commit 5f19d08 into kubeshop:main Aug 25, 2023
11 of 13 checks passed
@huseyinbabal huseyinbabal deleted the remove-slack-bot-user-param branch August 25, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josefkarasek josefkarasek josefkarasek approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193 PrasadG193 is a code owner

Assignees
No one assigned
Labels
bug Something isn't working ci Related to CI pipelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@huseyinbabal @josefkarasek