Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kettle subscribes to gs://kubernetes-ci-logs changes. #33628

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

michelle192837
Copy link
Contributor

@michelle192837 michelle192837 commented Oct 11, 2024

Switch kettle from the old PubSub subscription on kubernetes-jenkins to one on kubernetes-ci-logs.

Ref: #33381

(I believe no jobs care about this file, so this is just for consistency. The only auto-deploy job I found for Kettle is on the file in k8s.io:

)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 11, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michelle192837

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 11, 2024
@k8s-ci-robot k8s-ci-robot added area/kettle sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Oct 11, 2024
@ameukam
Copy link
Member

ameukam commented Oct 11, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2024
@k8s-ci-robot k8s-ci-robot merged commit e01be3e into kubernetes:master Oct 11, 2024
5 checks passed
@BenTheElder
Copy link
Member

note: I don't think we have an autodeploy for kettle.

https://kubernetes.slack.com/archives/CCK68P2Q2/p1729665831000469

@BenTheElder
Copy link
Member

running: make -C kettle deploy

@BenTheElder
Copy link
Member

... which doesn't work because the image doesn't exist, workaround: make -C kettle deploy TAG=latest

@michelle192837
Copy link
Contributor Author

I don't think it has autodeploy, but I did redeploy kettle after this change (and verified it picked up changes from the PubSub subscription for a while after redeploy). Metrics on the subscription in kubernetes-public (https://pantheon.corp.google.com/cloudpubsub/subscription/detail/k8s-infra-kettle?e=13803378&mods=monitoring_api_prod&project=kubernetes-public&pageState=(%22duration%22:(%22groupValue%22:%22%22,%22customValue%22:%5B%222024-10-01T17:22:10.462Z%22,%222024-10-23T17:22:10.462Z%22%5D))) should confirm that.

@michelle192837 michelle192837 deleted the kettle branch October 23, 2024 17:23
@BenTheElder
Copy link
Member

ah, thanks. it is not working however, I see a lot of errors in the logs about the build path being invalid in known bucket paths, meanwhile https://prow.k8s.io/job-history/gs/kubernetes-ci-logs/logs/metrics-kettle is failing due to the table being too old.

I think we need some more follow-up here.

@michelle192837
Copy link
Contributor Author

michelle192837 commented Oct 23, 2024

Agreed, yeah. I tried to take a look into it (https://kubernetes.slack.com/archives/C7J9RP96G/p1729200222410669), but I didn't find anything obvious from my attempts :(

Fwiw the invalid build path errors do seem to exist in logs before metrics-kettle started having issues. Might still be an issues with the bucket switch...

Oh wait yeah. The deployment is using gcr.io/k8s-staging-infra-tools/kettle, but the latest image there is the Apr. 24 image. Auto-pushed images are pushed to gcr.io/k8s-staging-test-infra/kettle.

Edit: I'll make a fix for it.

@BenTheElder
Copy link
Member

aha! thanks!

@BenTheElder
Copy link
Member

Yeah I was puzzling over the code versus the logs and nothing made sense, so I started reading through #33490

makes sense that we're just using stale images

@dims
Copy link
Member

dims commented Oct 23, 2024

thanks @michelle192837

@michelle192837
Copy link
Contributor Author

(Oh also I think we do have auto-deploy for k8s.io deployment.yaml changes, I forgot.

, https://testgrid.k8s.io/sig-k8s-infra-apps#deploy-kettle)

@dims
Copy link
Member

dims commented Oct 23, 2024

good to know :) one less thing to worry about

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kettle cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants