-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kettle subscribes to gs://kubernetes-ci-logs changes. #33628
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michelle192837 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
note: I don't think we have an autodeploy for kettle. https://kubernetes.slack.com/archives/CCK68P2Q2/p1729665831000469 |
running: |
... which doesn't work because the image doesn't exist, workaround: |
I don't think it has autodeploy, but I did redeploy kettle after this change (and verified it picked up changes from the PubSub subscription for a while after redeploy). Metrics on the subscription in kubernetes-public (https://pantheon.corp.google.com/cloudpubsub/subscription/detail/k8s-infra-kettle?e=13803378&mods=monitoring_api_prod&project=kubernetes-public&pageState=(%22duration%22:(%22groupValue%22:%22%22,%22customValue%22:%5B%222024-10-01T17:22:10.462Z%22,%222024-10-23T17:22:10.462Z%22%5D))) should confirm that. |
ah, thanks. it is not working however, I see a lot of errors in the logs about the build path being invalid in known bucket paths, meanwhile https://prow.k8s.io/job-history/gs/kubernetes-ci-logs/logs/metrics-kettle is failing due to the table being too old. I think we need some more follow-up here. |
Agreed, yeah. I tried to take a look into it (https://kubernetes.slack.com/archives/C7J9RP96G/p1729200222410669), but I didn't find anything obvious from my attempts :( Fwiw the invalid build path errors do seem to exist in logs before metrics-kettle started having issues. Might still be an issues with the bucket switch... Oh wait yeah. The deployment is using Edit: I'll make a fix for it. |
aha! thanks! |
Yeah I was puzzling over the code versus the logs and nothing made sense, so I started reading through #33490 makes sense that we're just using stale images |
thanks @michelle192837 |
(Oh also I think we do have auto-deploy for k8s.io deployment.yaml changes, I forgot.
|
good to know :) one less thing to worry about |
Switch kettle from the old PubSub subscription on kubernetes-jenkins to one on kubernetes-ci-logs.
Ref: #33381
(I believe no jobs care about this file, so this is just for consistency. The only auto-deploy job I found for Kettle is on the file in k8s.io:
test-infra/config/jobs/kubernetes/sig-k8s-infra/trusted/sig-k8s-infra-apps.yaml
Line 128 in cd57fdb