-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[20124] - Feature Request: Provide an option for passing a config file for addon configure command. #20129
base: master
Are you sure you want to change the base?
Conversation
Welcome @omleteer! |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: omleteer The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @omleteer. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Can one of the admins verify this patch? |
Minor UI Change (Before and After described in the ticket) but tl;dr:
BEFORE
Currently when configuring addons with the command:
eg:
The user is prompted to input the values one by one, eg:
and so on. This makes it hard to store/load values in a scripted environemnt. Some times it easier to provide a config file containing so that the values can be read from this.
AFTER
Add a "-c" local flag to the addon configure command, eg:
etc