-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DONT-MERGE: Kicbase/ISO: Update dependency versions - old- #20044
DONT-MERGE: Kicbase/ISO: Update dependency versions - old- #20044
Conversation
ok-to-build-image |
ok-to-build-iso |
Hi @minikube-bot. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: minikube-bot The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @minikube-bot, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further. |
Hi @minikube-bot, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further. |
/ok-to-test |
kvm2 driver with docker runtime
Times for minikube start: 48.6s 48.6s 50.7s 49.4s 49.0s Times for minikube ingress: 20.0s 18.5s 14.5s 16.0s 16.0s docker driver with docker runtime
Times for minikube start: 20.5s 21.0s 21.4s 21.5s 21.0s Times for minikube ingress: 13.3s 12.8s 13.3s 13.3s 12.8s docker driver with containerd runtime
Times for minikube start: 19.5s 20.0s 22.0s 22.5s 23.1s Times for minikube (PR 20044) ingress: 30.3s 38.7s 39.3s 38.8s 40.3s |
Here are the number of top 10 failed tests in each environments with lowest flake rate.
Besides the following environments also have failed tests:
To see the flake rates of all tests by environment, click here. |
I'm assuming the above test failure are related to nerdctl updating to 2.0 |
did it update to nerdctl 2 ? |
sure @medyagh, i had a look: looks like bumping nerdctl to v2 was (part of) the problem - so:
details: as seen in
indicating that this api call that docker made ( for minikube/cmd/minikube/cmd/docker-env.go Lines 315 to 338 in 3b895bd
replicating the issue
looking at the nerdctld service status:
and similarly in nerdctld logs:
so, the if we additionally take a look what
i made a pr proposing a fix for handling these cases in nerdctld, @afbjorklund please see if it make sense to you after
bottom line: regardless if we fix this specific issue or not, there could be others, so perhaps we would not want to partially upgrade some components towards transitioning to containerd v2 release, but do it intentionally in a separate effort instead (ie, i think we should not bump nerdctl as part of this pr) |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Changelog:
Update BuildKit from v0.16.0 to v0.18.1
Release notes
Update CNI Plugins from v1.6.0 to v1.6.1
Release notes
Update Go from 1.23.2 to 1.23.3
Update nerdctl from 1.7.7 to 2.0.1
Release notes
Update runc from v1.1.15 to v1.2.2
Release notes