Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translations: Fix translation on wrong line #19718

Merged
merged 1 commit into from
Sep 28, 2024

Conversation

spowelljr
Copy link
Member

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 27, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 27, 2024
@prezha prezha mentioned this pull request Sep 28, 2024
@uos-ljtian
Copy link
Contributor

There was a problem with the content I submitted. I'm very sorry. I will check it again next time.

@prezha
Copy link
Contributor

prezha commented Sep 28, 2024

no worries @uos-ljtian and thank you for the contribution!

you can use eg go test ./pkg/minikube/translate -run TestTranslationFilesValid -v for local testing

is this fix correct, please?

@uos-ljtian
Copy link
Contributor

The modification is correct

Copy link
Contributor

@prezha prezha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@uos-ljtian thanks for confirming!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: prezha, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spowelljr spowelljr merged commit c50fe68 into kubernetes:master Sep 28, 2024
7 of 8 checks passed
@spowelljr spowelljr deleted the fixTranslations branch September 28, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants