Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon headlamp: Update headlamp-k8s/headlamp image from v0.25.0 to v0.25.1 #19570

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

joaquimrocha
Copy link
Contributor

Upgrade Headlamp version to 0.25.1
cc: @joaquimrocha

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 3, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @joaquimrocha. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 3, 2024
@illume illume deleted the update_headlamp_0.25.1 branch September 3, 2024 20:36
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@spowelljr
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 9, 2024
@minikube-pr-bot

This comment has been minimized.

@minikube-pr-bot
Copy link

Here are the number of top 10 failed tests in each environments with lowest flake rate.

Environment Test Name Flake Rate
Docker_Linux_crio_arm64 (6 failed) TestFunctional/parallel/TunnelCmd/serial/WaitService/Setup(gopogh) 0.00% (chart)
Docker_Linux_crio_arm64 (6 failed) TestFunctional/parallel/TunnelCmd/serial/AccessDirect(gopogh) 0.00% (chart)
Docker_Linux_crio_arm64 (6 failed) TestFunctional/parallel/PersistentVolumeClaim(gopogh) 0.67% (chart)

Besides the following environments also have failed tests:

To see the flake rates of all tests by environment, click here.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joaquimrocha, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 10, 2024
@spowelljr
Copy link
Member

Hi @joaquimrocha, every time I try to merge the PR I get the following, could you try rebasing and see if that helps, I'm able to merge other PRs fine.

Screenshot 2024-09-12 at 8 42 33 AM

@joaquimrocha
Copy link
Contributor Author

Hi @spowelljr . I have been on vacation but I am back now. Let me see if there's anything I can do.

@spowelljr spowelljr merged commit 40087ac into kubernetes:master Sep 16, 2024
12 of 29 checks passed
@spowelljr
Copy link
Member

That fixed it, thanks!

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 19570) |
+-------------------+----------+---------------------+
| minikube start    | 47.0s    | 47.8s               |
| ⚠️  enable ingress | 15.7s    | 26.2s ⚠️             |
+-------------------+----------+---------------------+

Times for minikube (PR 19570) start: 48.0s 49.5s 44.7s 47.6s 49.1s
Times for minikube start: 47.0s 47.6s 47.6s 49.0s 43.6s

Times for minikube ingress: 14.9s 19.0s 14.9s 14.9s 14.9s
Times for minikube (PR 19570) ingress: 14.5s 14.4s 14.4s 13.9s 73.9s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 19570) |
+----------------+----------+---------------------+
| minikube start | 20.8s    | 21.3s               |
| enable ingress | 11.8s    | 12.3s               |
+----------------+----------+---------------------+

Times for minikube (PR 19570) start: 20.3s 23.5s 20.8s 21.3s 20.7s
Times for minikube start: 20.1s 20.0s 23.8s 20.3s 19.9s

Times for minikube ingress: 10.8s 12.7s 10.7s 12.7s 12.2s
Times for minikube (PR 19570) ingress: 10.7s 12.7s 12.8s 12.8s 12.7s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 19570) |
+----------------+----------+---------------------+
| minikube start | 20.7s    | 20.1s               |
| enable ingress | 27.4s    | 29.5s               |
+----------------+----------+---------------------+

Times for minikube start: 19.8s 18.5s 21.8s 23.4s 20.2s
Times for minikube (PR 19570) start: 19.5s 19.5s 19.4s 19.8s 22.5s

Times for minikube ingress: 28.7s 23.3s 23.2s 38.8s 23.2s
Times for minikube (PR 19570) ingress: 39.3s 23.2s 23.3s 22.7s 38.7s

@minikube-pr-bot
Copy link

Here are the number of top 10 failed tests in each environments with lowest flake rate.

Environment Test Name Flake Rate
KVM_Linux (3 failed) TestMultiControlPlane/serial/RestartClusterKeepsNodes(gopogh) 1.32% (chart)
KVM_Linux (3 failed) TestMultiControlPlane/serial/DeleteSecondaryNode(gopogh) 1.32% (chart)

Besides the following environments also have failed tests:

To see the flake rates of all tests by environment, click here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants