-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move ExtractFile from hyperkit to drivers #19468
Conversation
So that it can be used in other drivers too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afbjorklund, medyagh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
kvm2 driver with docker runtime
Times for minikube start: 49.6s 46.6s 48.8s 51.9s 49.3s Times for minikube (PR 19468) ingress: 14.5s 14.5s 15.1s 15.0s 15.0s docker driver with docker runtime
Times for minikube ingress: 13.3s 12.8s 12.8s 12.3s 12.8s Times for minikube start: 23.4s 21.3s 21.1s 23.7s 20.7s docker driver with containerd runtime
Times for minikube start: 20.8s 20.0s 23.3s 22.8s 23.5s Times for minikube ingress: 38.9s 38.8s 38.8s 22.8s 38.8s |
Here are the number of top 10 failed tests in each environments with lowest flake rate.
Besides the following environments also have failed tests:
To see the flake rates of all tests by environment, click here. |
So that it can be used in other drivers too
For instance the "vfkit" driver: #19423