-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow publish and download kicbase image in github release #19464
base: master
Are you sure you want to change the base?
feat: allow publish and download kicbase image in github release #19464
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ComradeProgrammer The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f5bc2ee
to
7ef2fb6
Compare
7ef2fb6
to
4e489bf
Compare
@spowelljr @medyagh updated |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
for ARCH in "amd64" "arm64" "arm/v7" "ppc64le" "s390x" | ||
do | ||
SUFFIX=$(echo $ARCH | sed 's/\///g') | ||
IMAGE_NAME=kicbase/stable:${KIC_VERSION} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we ensure that this image is already pushed into the registry ...otherwise it wont find it...(maybe it is somewhere up in the script that pushes the image)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@spowelljr is this the correct place to generate the tarball for new kicbase image? I guess this is a part of jenkins job, and the docker image should have been pushed into registry before this?
4e489bf
to
f23320a
Compare
/remove-lifecycle stale |
f23320a
to
d4761a8
Compare
d4761a8
to
3495065
Compare
3495065
to
0132ead
Compare
@ComradeProgrammer: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Line 3 in 0dbe96a
Does this go version make sense? Because if you run go list -m -json all , it is shown that k8s.io/apimachinery is using go version 1.23.0, so minikube's go version should not be less than 1.23.0 |
This PR include the following things: