-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "-o json" option for "minikube addon images" #19364
Conversation
Hi @thomasjm. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Can one of the admins verify this patch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems like a great feature and thanks for adding it, just a couple comments
/ok-to-test |
This comment has been minimized.
This comment has been minimized.
kvm2 driver with docker runtime
Times for minikube start: 53.7s 53.4s 50.8s 50.1s 51.8s Times for minikube (PR 19364) ingress: 23.9s 26.0s 27.9s 27.0s 23.9s docker driver with docker runtime
Times for minikube start: 21.9s 24.9s 21.0s 23.8s 22.4s Times for minikube ingress: 21.8s 21.3s 21.8s 21.7s 21.8s docker driver with containerd runtime
Times for minikube ingress: 47.3s 48.2s 47.3s 48.3s 48.2s Times for minikube (PR 19364) start: 20.2s 22.5s 23.5s 23.2s 23.7s |
Here are the number of top 10 failed tests in each environments with lowest flake rate.
Besides the following environments also have failed tests:
To see the flake rates of all tests by environment, click here. |
Here are the number of top 10 failed tests in each environments with lowest flake rate.
Besides the following environments also have failed tests:
To see the flake rates of all tests by environment, click here. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh, thomasjm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
thanks for this contribution, look forward to see more contributions |
I wanted to be able to programmatically consume the output of
minikube addon images ADDON_NAME
.The normal behavior is unchanged:
But now you can do
-o json
:$ minikube addons images gvisor -o json ["gcr.io/k8s-minikube/gvisor-addon:v0.0.1@sha256:d29adbddc7a44dab4c675c0eaea398907fe1f33f5f723274b0d40195b3076cae"]
Also fixed the grammar of the existing message from "has following images" to "has the following images."