WIP: Add QEMU functional tests #19299
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: spowelljr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
spowelljr
force-pushed
the
addQEMUFunctionalTests
branch
from
ab6bdad to
4c452c9
Compare
| if detect.IsAmd64M1Emulation() { | ||
| return "tcg" | ||
| } | ||
| if runtime.GOARCH == "arm64" && detect.GithubActionRunner() { |
There was a problem hiding this comment.
Gemini tells me
Flexibility: TCG allows QEMU to emulate a wide range of CPU architectures, even those not directly supported by the host system's hardware.
- Introduction — QEMU documentation
www.qemu.org
Portability: Since TCG is software-based, QEMU can run on various platforms without requiring specialized hardware for each architecture.
so I am guessing this might mean we can use tcg on windows too
There was a problem hiding this comment.
Only for the slow path, which is not something that is recommended for running Kubernetes with
It should start with "whpx", and only use tcg if running on the wrong Architecture (like on Windows ARM)
k8s-ci-robot
added
the
do-not-merge/work-in-progress
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
needs-rebase
|
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
k8s-ci-robot
added
the
lifecycle/stale
|
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
k8s-ci-robot
added
lifecycle/rotten
Added functional test for QEMU that run on
macos-14runners (arm64).If using the QEMU driver on GitHub Action runners, doubled the number of attempts to get the VM IP from the
dhcpd_leasesfile (from 60 to 120).Set the
-cpuQEMU flag tomax& the-accelQEMU flag totcgif running on an arm64 macOS GitHub Action runner.