Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: check connectivity outside minikube once it fails #18859

Merged
merged 7 commits into from
Jul 15, 2024

Conversation

ComradeProgrammer
Copy link
Member

feat: check connectivity outside minikube once it fails

FIX #18754
After

$ ./out/minikube start       
😄  minikube v1.33.0 on Darwin 14.4.1 (arm64)
✨  Automatically selected the docker driver. Other choices: qemu2, ssh
📌  Using Docker Desktop driver with root privileges
👍  Starting "minikube" primary control-plane node in "minikube" cluster
🚜  Pulling base image v0.0.44 ...
🔥  Creating docker container (CPUs=2, Memory=6100MB) ...
❗  This container is having trouble accessing https://registry.k8s.io inside the minikube
💡  To pull new external images, you may need to configure a proxy: https://minikube.sigs.k8s.io/docs/reference/networking/proxy/
❗  This container is also having trouble accessing https://registry.k8s.io outside the minikube 
🐳  Preparing Kubernetes v1.30.0 on Docker 26.1.1 ...
    ▪ Generating certificates and keys ...
    ▪ Booting up control plane ...
    ▪ Configuring RBAC rules ...
🔗  Configuring bridge CNI (Container Networking Interface) ...
🔎  Verifying Kubernetes components...
    ▪ Using image gcr.io/k8s-minikube/storage-provisioner:v5
🌟  Enabled addons: storage-provisioner, default-storageclass
🏄  Done! kubectl is now configured to use "minikube" cluster and "default" namespace by default

This container is also having trouble accessing https://registry.k8s.io outside the minikube is also printed on the console

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 12, 2024
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 12, 2024
pkg/minikube/node/start.go Show resolved Hide resolved
pkg/minikube/node/start.go Outdated Show resolved Hide resolved
@medyagh
Copy link
Member

medyagh commented Jun 17, 2024

please update the description with the new UI

@medyagh
Copy link
Member

medyagh commented Jun 17, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jun 17, 2024
@minikube-pr-bot

This comment has been minimized.

pkg/minikube/node/start.go Outdated Show resolved Hide resolved
pkg/minikube/node/start.go Outdated Show resolved Hide resolved
pkg/minikube/node/start.go Outdated Show resolved Hide resolved
pkg/minikube/node/start.go Outdated Show resolved Hide resolved
@minikube-pr-bot

This comment has been minimized.

ComradeProgrammer and others added 2 commits June 30, 2024 15:20
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 30, 2024
@minikube-pr-bot

This comment has been minimized.

@minikube-pr-bot

This comment has been minimized.

pkg/minikube/node/start.go Outdated Show resolved Hide resolved
pkg/minikube/node/start.go Outdated Show resolved Hide resolved
ComradeProgrammer and others added 2 commits July 4, 2024 00:26
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 3, 2024
@minikube-pr-bot

This comment has been minimized.

pkg/minikube/node/start.go Outdated Show resolved Hide resolved
@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux_containerd TestMissingContainerUpgrade (gopogh) 0.00 (chart)
Hyperkit_macOS TestNetworkPlugins/group/bridge/HairPin (gopogh) 0.00 (chart)
Docker_Linux_containerd_arm64 TestAddons/parallel/Volcano (gopogh) 2.17 (chart)
Docker_Linux_containerd_arm64 TestAddons/parallel/InspektorGadget (gopogh) 2.90 (chart)
Docker_Linux_containerd_arm64 TestAddons/StoppedEnableDisable (gopogh) 2.90 (chart)

To see the flake rates of all tests by environment, click here.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 14, 2024
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 18859) |
+----------------+----------+---------------------+
| minikube start | 48.0s    | 48.9s               |
| enable ingress | 24.4s    | 23.9s               |
+----------------+----------+---------------------+

Times for minikube start: 46.7s 46.5s 48.4s 50.4s 48.2s
Times for minikube (PR 18859) start: 47.3s 50.8s 49.6s 50.9s 45.9s

Times for minikube ingress: 25.0s 22.9s 24.4s 26.9s 22.9s
Times for minikube (PR 18859) ingress: 24.0s 23.9s 24.5s 23.0s 24.0s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 18859) |
+----------------+----------+---------------------+
| minikube start | 23.8s    | 22.8s               |
| enable ingress | 22.0s    | 21.9s               |
+----------------+----------+---------------------+

Times for minikube ingress: 21.8s 21.8s 21.8s 23.3s 21.3s
Times for minikube (PR 18859) ingress: 21.3s 21.8s 21.8s 22.8s 21.8s

Times for minikube start: 24.1s 23.7s 21.8s 24.9s 24.6s
Times for minikube (PR 18859) start: 22.0s 25.0s 24.5s 21.2s 21.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 18859) |
+----------------+----------+---------------------+
| minikube start | 21.2s    | 20.3s               |
| enable ingress | 35.1s    | 31.5s               |
+----------------+----------+---------------------+

Times for minikube start: 21.9s 20.8s 23.6s 19.5s 20.4s
Times for minikube (PR 18859) start: 20.9s 19.8s 19.8s 21.6s 19.7s

Times for minikube ingress: 32.3s 31.8s 47.8s 31.8s 31.8s
Times for minikube (PR 18859) ingress: 30.8s 32.3s 31.3s 30.8s 32.3s

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ComradeProgrammer, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 15, 2024
@spowelljr spowelljr merged commit e14f99e into kubernetes:master Jul 15, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tryRegistry fuc should once it i fails, should try outside minikube
6 participants