Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Build auto-pause-hook for all architectures #17869

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

spowelljr
Copy link
Member

Before, running make push-auto-pause-hook-image would only build the auto-pause-hook for the arch of the machine running the command on. Modified the Dockerfile and Makefile target to build an image for each architecture.

Also updated the Dockerfile to a multi-step build so the base image is from scratch instead of golang. Resulting in the image going from 790MB to 45MB, greatly increasing the speed of enabling the addon for people with slow internet speeds.

Before:

REPOSITORY                            TAG                        IMAGE ID       CREATED          SIZE
gcr.io/k8s-minikube/auto-pause-hook   v0.0.4                     a633c3ce5969   9 months ago     790MB

After:

REPOSITORY                            TAG                        IMAGE ID       CREATED          SIZE
gcr.io/k8s-minikube/auto-pause-hook   v0.0.5                     37295df93934   2 months ago     45MB

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 28, 2023
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 28, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as part of this PR we should ensure the image is pushed

@spowelljr
Copy link
Member Author

spowelljr commented Jan 8, 2024

The image is pushed

$ docker pull gcr.io/k8s-minikube/auto-pause-hook:v0.0.5
v0.0.5: Pulling from k8s-minikube/auto-pause-hook
6c99d14f8e2e: Pull complete 
Digest: sha256:d613ed2c891882b602b5aca668e92d4606a1b3832d96750ab25804de15929522
Status: Downloaded newer image for gcr.io/k8s-minikube/auto-pause-hook:v0.0.5
gcr.io/k8s-minikube/auto-pause-hook:v0.0.5

@spowelljr spowelljr merged commit 5a7cff2 into kubernetes:master Jan 8, 2024
27 of 30 checks passed
@spowelljr spowelljr deleted the autoPauseMultiarch branch January 8, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants