Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addons headlamp: Improve enable outputs #17776

Merged
merged 3 commits into from
Jan 10, 2024

Conversation

spowelljr
Copy link
Member

@spowelljr spowelljr commented Dec 12, 2023

Add profile to command output

Before:

$ minikube -p p2 start --addons headlamp
...
💡  To access Headlamp, use the following command:
minikube service headlamp -n headlamp
...

After:

$ minikube -p p2 start --addons headlamp
...
💡  To access Headlamp, use the following command:
minikube -p p2 service headlamp -n headlamp
...

Fix formatting of output

Before:

$ minikube addons enable headlamp
❗  headlamp is a 3rd party addon and is not maintained or verified by minikube maintainers, enable at your own risk.
💡  headlamp is maintained by 3rd party (kinvolk.io) for any concerns contact yolossn on GitHub.
    ▪ Using image ghcr.io/headlamp-k8s/headlamp:v0.21.0
💡  To access Headlamp, use the following command:
minikube service headlamp -n headlamp


💡  To authenticate in Headlamp, fetch the Authentication Token using the following command:
kubectl create token headlamp --duration 24h -n headlamp

💡  Headlamp can display more detailed information when metrics-server is installed. To install it, run:

minikube addons enable metrics-server	


🌟  The 'headlamp' addon is enabled

After:

$ minikube addons enable headlamp
❗  headlamp is a 3rd party addon and is not maintained or verified by minikube maintainers, enable at your own risk.
💡  headlamp is maintained by 3rd party (kinvolk.io) for any concerns contact yolossn on GitHub.
    ▪ Using image ghcr.io/headlamp-k8s/headlamp:v0.21.0
💡  To access Headlamp, use the following command:

	minikube service headlamp -n headlamp

💡  To authenticate in Headlamp, fetch the Authentication Token using the following command:

        kubectl create token headlamp --duration 24h -n headlamp

💡  Headlamp can display more detailed information when metrics-server is installed. To install it, run:

	minikube addons enable metrics-server

🌟  The 'headlamp' addon is enabled

Also removed duplicate newline from dashboard and yakd output.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 12, 2023
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 12, 2023
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 20, 2023
@spowelljr spowelljr changed the title addons headlamp: Add profile to command output addons headlamp: Improve enable outputs Dec 20, 2023
@medyagh medyagh merged commit 2c8c605 into kubernetes:master Jan 10, 2024
18 of 21 checks passed
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spowelljr spowelljr deleted the addProfileToCommand branch January 10, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants