Add more description in node add --worker option to inform adding control plane nodes is not available

[kimsehwan96]

fixes: #17680

This changes are related with minikube's document and command line options.

[k8s-ci-robot]

Welcome @kimsehwan96!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @kimsehwan96. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[minikube-bot]

Can one of the admins verify this patch?

[medyagh]

/ok-to-test

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kimsehwan96, medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [medyagh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[minikube-pr-bot]

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 17681) |
+----------------+----------+---------------------+
| minikube start | 51.4s    | 50.8s               |
| enable ingress | 26.2s    | 25.9s               |
+----------------+----------+---------------------+

Times for minikube start: 54.5s 49.8s 49.2s 53.2s 50.0s
Times for minikube (PR 17681) start: 49.9s 51.0s 49.3s 51.6s 52.2s

Times for minikube ingress: 28.0s 28.2s 24.1s 22.7s 28.1s
Times for minikube (PR 17681) ingress: 27.2s 25.1s 24.7s 24.6s 28.1s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 17681) |
+----------------+----------+---------------------+
| minikube start | 23.4s    | 22.2s               |
| enable ingress | 20.4s    | 20.5s               |
+----------------+----------+---------------------+

Times for minikube start: 25.0s 22.9s 22.3s 22.3s 24.8s
Times for minikube (PR 17681) start: 21.9s 22.0s 21.8s 22.4s 22.9s

Times for minikube (PR 17681) ingress: 21.8s 20.3s 18.8s 20.8s 20.8s
Times for minikube ingress: 20.9s 18.8s 18.8s 20.9s 22.8s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 17681) |
+----------------+----------+---------------------+
| minikube start | 21.9s    | 22.6s               |
| enable ingress | 28.9s    | 28.7s               |
+----------------+----------+---------------------+

Times for minikube ingress: 31.4s 31.3s 31.3s 19.3s 31.3s
Times for minikube (PR 17681) ingress: 31.3s 31.3s 18.3s 31.3s 31.3s

Times for minikube start: 20.6s 21.6s 22.9s 23.6s 20.8s
Times for minikube (PR 17681) start: 20.6s 23.5s 21.5s 24.1s 23.6s

[minikube-pr-bot]

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_Linux_crio	TestStartStop/group/no-preload/serial/DeployApp (gopogh)	0.58 (chart)
Docker_Linux_crio	TestStartStop/group/no-preload/serial/EnableAddonWhileActive (gopogh)	0.58 (chart)
Docker_Linux_crio	TestStartStop/group/no-preload/serial/FirstStart (gopogh)	0.58 (chart)
Docker_Windows	TestNoKubernetes/serial/StartNoArgs (gopogh)	2.55 (chart)
Hyperkit_macOS	TestStartStop/group/newest-cni/serial/EnableAddonWhileActive (gopogh)	4.49 (chart)
KVM_Linux_crio	TestStartStop/group/newest-cni/serial/EnableAddonAfterStop (gopogh)	11.83 (chart)
KVM_Linux_crio	TestStartStop/group/newest-cni/serial/Stop (gopogh)	11.83 (chart)

To see the flake rates of all tests by environment, click here.

[kimsehwan96]

@medyagh There is any reason why this PR was not merged?

I think that the failed test might be the reason..., Do I need to check about this failed test ?

Thank you.

[prezha]

with pr #17909 we aim to enable support for multi-control-plane (ie, ha) topology, incl. --control-plane flag for adding more control-plane nodes to an existing ha cluster

[kimsehwan96]

@prezha It looks greate. Thank you for your supporting to enable this feature :).

Then, I will not do anything about this PR then. :) When It's flag really works then this PR should be closed.

[caerulescens]

this is awesome! thank you