Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build(deps): Bump libvirt.org/go/libvirt from 1.9007.0 to 1.9008.0 #17609

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 13, 2023

Bumps libvirt.org/go/libvirt from 1.9007.0 to 1.9008.0.

Commits
  • d55645b Allow empty string for SaveFlags
  • b398406 Add support for network event for metadata change
  • 18919ee Re-generate API bindings with libvirt 9.8.0
  • 6c9bec2 docs: go fmt
  • b3d06a0 connect: Allow obtaining raw connect pointer
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [libvirt.org/go/libvirt](https://gitlab.com/libvirt/libvirt-go-module) from 1.9007.0 to 1.9008.0.
- [Commits](https://gitlab.com/libvirt/libvirt-go-module/compare/v1.9007.0...v1.9008.0)

---
updated-dependencies:
- dependency-name: libvirt.org/go/libvirt
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Nov 13, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 13, 2023
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 13, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 13, 2023
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@spowelljr
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 14, 2023
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 17609) |
+----------------+----------+---------------------+
| minikube start | 50.2s    | 50.1s               |
| enable ingress | 26.4s    | 27.1s               |
+----------------+----------+---------------------+

Times for minikube start: 48.7s 50.5s 51.6s 50.3s 49.7s
Times for minikube (PR 17609) start: 49.8s 48.2s 49.1s 50.5s 52.9s

Times for minikube ingress: 27.6s 28.6s 23.6s 26.7s 25.6s
Times for minikube (PR 17609) ingress: 24.2s 27.6s 27.2s 27.2s 29.2s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 17609) |
+----------------+----------+---------------------+
| minikube start | 24.0s    | 22.7s               |
| enable ingress | 21.2s    | 20.8s               |
+----------------+----------+---------------------+

Times for minikube ingress: 20.9s 20.9s 20.8s 20.8s 22.4s
Times for minikube (PR 17609) ingress: 20.9s 20.8s 20.8s 20.9s 20.8s

Times for minikube start: 24.6s 25.0s 24.2s 24.3s 21.7s
Times for minikube (PR 17609) start: 21.1s 22.8s 24.8s 22.6s 22.4s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 17609) |
+----------------+----------+---------------------+
| minikube start | 22.2s    | 21.5s               |
| enable ingress | 31.7s    | 31.3s               |
+----------------+----------+---------------------+

Times for minikube start: 21.5s 21.4s 21.3s 23.3s 23.6s
Times for minikube (PR 17609) start: 21.0s 23.3s 21.7s 21.1s 20.3s

Times for minikube (PR 17609) ingress: 31.3s 31.3s 31.4s 31.3s 31.4s
Times for minikube ingress: 32.3s 31.3s 31.3s 32.3s 31.3s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Windows TestNetworkPlugins/group/bridge/Start (gopogh) 0.72 (chart)
Docker_Linux_crio_arm64 TestScheduledStopUnix (gopogh) 4.82 (chart)
QEMU_macOS TestMinikubeProfile (gopogh) 6.21 (chart)
KVM_Linux TestMultiNode/serial/RestartMultiNode (gopogh) 7.23 (chart)
Docker_Linux_crio TestPause/serial/SecondStartNoReconfiguration (gopogh) 7.98 (chart)

To see the flake rates of all tests by environment, click here.

@spowelljr spowelljr merged commit ed60447 into master Nov 14, 2023
40 of 56 checks passed
@spowelljr spowelljr deleted the dependabot/go_modules/libvirt.org/go/libvirt-1.9008.0 branch November 14, 2023 17:54
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dependabot[bot], spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. dependencies Pull requests that update a dependency file go Pull requests that update Go code ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants