Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fix image path in cached-images #17413

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

spowelljr
Copy link
Member

Was using the old format before arch specific image were introduced, also not breaking down image pathing by registry

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 12, 2023
@spowelljr
Copy link
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Oct 12, 2023
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 12, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spowelljr
Copy link
Member Author

/retest-this-please

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 17413) |
+----------------+----------+---------------------+
| minikube start | 50.9s    | 50.3s               |
| enable ingress | 27.9s    | 28.1s               |
+----------------+----------+---------------------+

Times for minikube start: 53.4s 49.0s 49.8s 50.3s 52.1s
Times for minikube (PR 17413) start: 48.9s 49.9s 49.9s 53.4s 49.3s

Times for minikube ingress: 28.2s 27.1s 28.1s 28.2s 27.7s
Times for minikube (PR 17413) ingress: 28.1s 28.1s 28.1s 28.2s 28.1s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 17413) |
+----------------+----------+---------------------+
| minikube start | 24.4s    | 24.5s               |
| enable ingress | 21.5s    | 21.0s               |
+----------------+----------+---------------------+

Times for minikube ingress: 20.8s 21.9s 21.9s 21.8s 20.9s
Times for minikube (PR 17413) ingress: 21.4s 20.9s 20.8s 20.9s 20.9s

Times for minikube start: 25.2s 25.6s 24.6s 21.6s 25.0s
Times for minikube (PR 17413) start: 25.1s 24.5s 24.9s 25.6s 22.4s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 17413) |
+----------------+----------+---------------------+
| minikube start | 22.3s    | 23.3s               |
| enable ingress | 30.0s    | 32.2s               |
+----------------+----------+---------------------+

Times for minikube start: 21.4s 21.1s 23.1s 21.4s 24.2s
Times for minikube (PR 17413) start: 23.4s 23.7s 23.6s 24.9s 20.7s

Times for minikube ingress: 31.3s 33.3s 20.4s 32.4s 32.4s
Times for minikube (PR 17413) ingress: 32.4s 33.4s 31.4s 32.3s 31.3s

@medyagh medyagh merged commit 79e8c3f into kubernetes:master Oct 13, 2023
27 of 28 checks passed
@spowelljr spowelljr deleted the fixCacheTest branch October 13, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants