Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QEMU: Fix addons failing to enable #17402

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

spowelljr
Copy link
Member

Fixes #17396

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 11, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 11, 2023
@medyagh
Copy link
Member

medyagh commented Oct 11, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Oct 11, 2023
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 17402) |
+----------------+----------+---------------------+
| minikube start | 52.6s    | 50.9s               |
| enable ingress | 28.0s    | 28.2s               |
+----------------+----------+---------------------+

Times for minikube ingress: 28.3s 27.7s 28.2s 28.2s 27.7s
Times for minikube (PR 17402) ingress: 28.2s 27.6s 28.7s 28.7s 27.7s

Times for minikube start: 51.2s 51.1s 55.7s 51.4s 53.5s
Times for minikube (PR 17402) start: 50.4s 50.9s 52.5s 51.6s 49.3s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 17402) |
+----------------+----------+---------------------+
| minikube start | 23.5s    | 23.7s               |
| enable ingress | 21.4s    | 20.9s               |
+----------------+----------+---------------------+

Times for minikube start: 24.6s 21.2s 24.5s 22.4s 24.5s
Times for minikube (PR 17402) start: 22.1s 21.8s 25.4s 24.3s 24.8s

Times for minikube ingress: 20.8s 20.8s 21.8s 21.8s 21.8s
Times for minikube (PR 17402) ingress: 20.9s 20.8s 20.8s 21.4s 20.8s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 17402) |
+----------------+----------+---------------------+
| minikube start | 22.3s    | 21.6s               |
| enable ingress | 31.5s    | 31.5s               |
+----------------+----------+---------------------+

Times for minikube start: 22.4s 20.8s 23.4s 21.0s 23.6s
Times for minikube (PR 17402) start: 20.4s 23.4s 24.0s 20.0s 19.9s

Times for minikube ingress: 31.3s 32.3s 31.3s 31.3s 31.3s
Times for minikube (PR 17402) ingress: 31.3s 32.3s 31.3s 31.3s 31.3s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Windows TestPause/serial/SecondStartNoReconfiguration (gopogh) 14.00 (chart)
Hyperkit_macOS TestFunctional/parallel/CertSync (gopogh) 27.03 (chart)
Hyperkit_macOS TestFunctional/parallel/CpCmd (gopogh) 27.03 (chart)
Hyperkit_macOS TestFunctional/parallel/DashboardCmd (gopogh) 27.03 (chart)
Hyperkit_macOS TestFunctional/parallel/DockerEnv/bash (gopogh) 27.03 (chart)
Hyperkit_macOS TestFunctional/parallel/FileSync (gopogh) 27.03 (chart)
Hyperkit_macOS TestFunctional/parallel/ImageCommands/ImageBuild (gopogh) 27.03 (chart)
Hyperkit_macOS TestFunctional/parallel/ImageCommands/ImageListJson (gopogh) 27.03 (chart)
Hyperkit_macOS TestFunctional/parallel/ImageCommands/ImageListTable (gopogh) 27.03 (chart)
Hyperkit_macOS TestFunctional/parallel/ImageCommands/ImageListYaml (gopogh) 27.03 (chart)
Hyperkit_macOS TestFunctional/parallel/ImageCommands/ImageLoadDaemon (gopogh) 27.03 (chart)
Hyperkit_macOS TestFunctional/parallel/ImageCommands/ImageLoadFromFile (gopogh) 27.03 (chart)
Hyperkit_macOS TestFunctional/parallel/ImageCommands/ImageReloadDaemon (gopogh) 27.03 (chart)
Hyperkit_macOS TestFunctional/parallel/ImageCommands/ImageSaveToFile (gopogh) 27.03 (chart)
Hyperkit_macOS TestFunctional/parallel/ImageCommands/ImageTagAndLoadDaemon (gopogh) 27.03 (chart)
Hyperkit_macOS TestFunctional/parallel/MySQL (gopogh) 27.03 (chart)
Hyperkit_macOS TestFunctional/parallel/NodeLabels (gopogh) 27.03 (chart)
Hyperkit_macOS TestFunctional/parallel/NonActiveRuntimeDisabled (gopogh) 27.03 (chart)
Hyperkit_macOS TestFunctional/parallel/PersistentVolumeClaim (gopogh) 27.03 (chart)
Hyperkit_macOS TestFunctional/parallel/ServiceCmdConnect (gopogh) 27.03 (chart)
Hyperkit_macOS TestFunctional/parallel/ServiceCmd/DeployApp (gopogh) 27.03 (chart)
Hyperkit_macOS TestFunctional/parallel/ServiceCmd/Format (gopogh) 27.03 (chart)
Hyperkit_macOS TestFunctional/parallel/ServiceCmd/HTTPS (gopogh) 27.03 (chart)
Hyperkit_macOS TestFunctional/parallel/ServiceCmd/JSONOutput (gopogh) 27.03 (chart)
Hyperkit_macOS TestFunctional/parallel/ServiceCmd/List (gopogh) 27.03 (chart)
Hyperkit_macOS TestFunctional/parallel/ServiceCmd/URL (gopogh) 27.03 (chart)
Hyperkit_macOS TestFunctional/parallel/SSHCmd (gopogh) 27.03 (chart)
Hyperkit_macOS TestFunctional/parallel/StatusCmd (gopogh) 27.03 (chart)
Hyperkit_macOS TestFunctional/parallel/TunnelCmd/serial/AccessDirect (gopogh) 27.03 (chart)
Hyperkit_macOS TestFunctional/parallel/TunnelCmd/serial/AccessThroughDNS (gopogh) 27.03 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@medyagh medyagh merged commit 74851f3 into kubernetes:master Oct 13, 2023
28 checks passed
@spowelljr spowelljr deleted the qemuAddonEnable branch October 24, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Starting with QEMU storage-provisioner sometimes fails to enable
4 participants