Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix delete if container-runtime doesn't exist #17347

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

spowelljr
Copy link
Member

Before:

$ minikube delete

❌  Exiting due to MK_NEW_RUNTIME: Failed to create runtime: unknown runtime type: "nvidia-docker"

╭───────────────────────────────────────────────────────────────────────────────────────────╮
│                                                                                           │
│    😿  If the above advice does not help, please let us know:                             │
│    👉  https://github.com/kubernetes/minikube/issues/new/choose                           │
│                                                                                           │
│    Please run `minikube logs --file=logs.txt` and attach logs.txt to the GitHub issue.    │
│    Please also attach the following file to the GitHub issue:                             │
│    - /tmp/minikube_delete_8e4d16ba2ead342287e31d85ea41bad14bfe469f_0.log                  │
│                                                                                           │
╰───────────────────────────────────────────────────────────────────────────────────────────╯

After:

$ minikube delete
🔥  Deleting "minikube" in docker ...
🔥  Deleting container "minikube" ...
🔥  Removing /usr/local/google/home/powellsteven/.minikube/machines/minikube ...
💀  Removed all traces of the "minikube" cluster.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 3, 2023
@spowelljr spowelljr changed the title Fix delete if CRI doesn't exist Fix delete if container-runtime doesn't exist Oct 3, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 3, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 3, 2023
@medyagh
Copy link
Member

medyagh commented Oct 4, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Oct 4, 2023
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 17347) |
+----------------+----------+---------------------+
| minikube start | 50.0s    | 50.2s               |
| enable ingress | 28.2s    | 28.6s               |
+----------------+----------+---------------------+

Times for minikube ingress: 29.2s 27.2s 28.2s 28.6s 28.1s
Times for minikube (PR 17347) ingress: 29.1s 29.6s 27.7s 28.7s 28.2s

Times for minikube start: 49.5s 49.5s 51.0s 50.1s 50.0s
Times for minikube (PR 17347) start: 51.6s 47.9s 50.5s 49.6s 51.3s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 17347) |
+----------------+----------+---------------------+
| minikube start | 22.6s    | 23.1s               |
| enable ingress | 20.8s    | 21.5s               |
+----------------+----------+---------------------+

Times for minikube start: 23.6s 21.8s 23.9s 21.6s 22.0s
Times for minikube (PR 17347) start: 21.5s 21.6s 25.2s 22.4s 24.6s

Times for minikube ingress: 20.8s 20.8s 20.8s 20.8s 20.9s
Times for minikube (PR 17347) ingress: 22.3s 20.8s 20.8s 22.8s 20.8s

docker driver with containerd runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 17347) |
+-------------------+----------+---------------------+
| minikube start    | 22.3s    | 22.1s               |
| ⚠️  enable ingress | 26.7s    | 34.5s ⚠️             |
+-------------------+----------+---------------------+

Times for minikube start: 21.0s 23.5s 23.4s 23.0s 20.7s
Times for minikube (PR 17347) start: 23.5s 20.7s 23.3s 20.5s 22.5s

Times for minikube ingress: 19.3s 31.3s 32.3s 31.3s 19.4s
Times for minikube (PR 17347) ingress: 31.3s 31.4s 47.3s 31.3s 31.3s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
KVM_Linux_crio TestStartStop/group/default-k8s-diff-port/serial/Pause (gopogh) 0.00 (chart)
KVM_Linux TestStoppedBinaryUpgrade/Upgrade (gopogh) 0.00 (chart)
Hyperkit_macOS TestNetworkPlugins/group/calico/Start (gopogh) 1.89 (chart)
KVM_Linux TestStartStop/group/default-k8s-diff-port/serial/VerifyKubernetesImages (gopogh) 3.12 (chart)
Hyperkit_macOS TestImageBuild/serial/Setup (gopogh) 3.77 (chart)
KVM_Linux TestStartStop/group/default-k8s-diff-port/serial/AddonExistsAfterStop (gopogh) 3.91 (chart)
KVM_Linux TestStartStop/group/default-k8s-diff-port/serial/Pause (gopogh) 3.91 (chart)
KVM_Linux TestStartStop/group/default-k8s-diff-port/serial/SecondStart (gopogh) 3.91 (chart)
KVM_Linux TestStartStop/group/default-k8s-diff-port/serial/UserAppExistsAfterStop (gopogh) 3.91 (chart)
QEMU_macOS TestFunctional/parallel/PersistentVolumeClaim (gopogh) 6.78 (chart)
QEMU_macOS TestFunctional/parallel/TunnelCmd/serial/RunSecondTunnel (gopogh) 49.15 (chart)

To see the flake rates of all tests by environment, click here.

@medyagh medyagh merged commit 9ff7852 into kubernetes:master Oct 4, 2023
27 of 28 checks passed
@spowelljr spowelljr deleted the fixCRIDelete branch October 5, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants