-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate installing NVIDIA Container Toolkit --container-runtime #17287
Conversation
spowelljr
commented
Sep 20, 2023
•
edited
Loading
edited
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: spowelljr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
a569fbb
to
091ff2d
Compare
/ok-to-test |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
kvm2 driver with docker runtime
Times for minikube start: 48.2s 51.3s 50.3s 50.4s 51.0s Times for minikube ingress: 27.1s 25.2s 27.7s 26.7s 28.1s docker driver with docker runtime
Times for minikube start: 24.7s 25.1s 22.1s 24.1s 25.7s Times for minikube ingress: 20.8s 21.3s 21.3s 20.8s 20.8s docker driver with containerd runtime
Times for minikube start: 23.4s 20.8s 23.8s 24.7s 23.7s Times for minikube ingress: 31.3s 31.3s 47.3s 18.4s 31.4s |
These are the flake rates of all failed tests.
Too many tests failed - See test logs for more details. To see the flake rates of all tests by environment, click here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets try to make another PR that will keep container runtimes 3 and have a flag called --enable-nvidia that way if we later have amd-gpu and also containerd and crio we could enable it fo rthem
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |