Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add github action for running minikube-image-benchmark #17058

Merged
merged 1 commit into from
Sep 28, 2023
Merged

add github action for running minikube-image-benchmark #17058

merged 1 commit into from
Sep 28, 2023

Conversation

ComradeProgrammer
Copy link
Member

@ComradeProgrammer ComradeProgrammer commented Aug 14, 2023 •
edited
Loading

This PR has been revised according to the talk in previous office Hour

Now it shows the performance of different commands under different circumstances according to the time

2 pictures will be generated and uploaded to S3

Here are the examples of the picture This picture is generated with fake data

Iterative_buildpacksFewLargeFiles_containerd_chart
Iterative_buildpacksFewLargeFiles_docker_chart

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 14, 2023
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 14, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @ComradeProgrammer. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 14, 2023
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@ComradeProgrammer ComradeProgrammer force-pushed the build_and_run_action branch 2 times, most recently from d3ab243 to 7793029 Compare August 27, 2023 08:57
@ComradeProgrammer
Copy link
Member Author

ComradeProgrammer commented Aug 27, 2023 •
edited
Loading

@medyagh @spowelljr could you please have a look at the revised PR?

Now it shows the performance changes over time, as we have discussed in the previous office hour.

Thanks

medyagh
medyagh requested changes Sep 11, 2023
View reviewed changes
Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets have one chart per container runtime

medyagh
medyagh requested changes Sep 11, 2023
View reviewed changes
hack/benchmark/build_and_run/publish-chart.sh Outdated Show resolved Hide resolved
hack/benchmark/build_and_run/generate-chart.go Outdated Show resolved Hide resolved
@ComradeProgrammer ComradeProgrammer force-pushed the build_and_run_action branch 3 times, most recently from 63501f7 to 2d5526a Compare September 21, 2023 16:23
@ComradeProgrammer
Copy link
Member Author

@medyagh the comments have been solved

but it seems that the automation test cannot pull submodule correctly

@medyagh
Copy link
Member

medyagh commented Sep 21, 2023

@medyagh the comments have been solved

but it seems that the automation test cannot pull submodule correctly

yeah plz check how we can fix this https://app.netlify.com/sites/kubernetes-sigs-minikube/deploys/650c6df8085de50008eb8ece

@medyagh
Copy link
Member

medyagh commented Sep 21, 2023

we should not break deploy/netlify

@ComradeProgrammer ComradeProgrammer force-pushed the build_and_run_action branch 2 times, most recently from 2708fa2 to e674627 Compare September 21, 2023 20:51
@medyagh
Copy link
Member

medyagh commented Sep 25, 2023

@ComradeProgrammer plz fix the lint

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ComradeProgrammer, medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 27, 2023
@medyagh medyagh merged commit f881b33 into kubernetes:master Sep 28, 2023
12 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh approved these changes

@sharifelgamal sharifelgamal Awaiting requested review from sharifelgamal

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ComradeProgrammer @k8s-ci-robot @minikube-bot @medyagh