-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Istio Operator #16905
Update Istio Operator #16905
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rschoebel The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @rschoebel! |
Hi @rschoebel. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Can one of the admins verify this patch? |
/ok-to-test |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rschoebel do u mind posting Before/After this PR output to ensure this is not breaking ?
This comment has been minimized.
This comment has been minimized.
/retest-this-please |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
from version 1.12.1 -> 1.18.1
kvm2 driver with docker runtime
Times for minikube start: 52.4s 50.9s 48.9s 51.8s 51.0s Times for minikube ingress: 28.6s 27.6s 28.1s 28.3s 28.1s docker driver with docker runtime
Times for minikube start: 22.7s 21.5s 22.6s 27.1s 25.0s Times for minikube ingress: 20.8s 19.8s 20.8s 21.8s 20.9s docker driver with containerd runtime
Times for minikube (PR 16905) start: 23.4s 22.8s 21.2s 23.6s 23.9s Times for minikube ingress: 31.3s 31.3s 31.3s 31.3s 30.3s |
@@ -275,7 +275,7 @@ var Addons = map[string]*Addon{ | |||
"istio-operator.yaml", | |||
"0640"), | |||
}, false, "istio-provisioner", "3rd party (Istio)", "", "https://istio.io/latest/docs/setup/platform-setup/minikube/", map[string]string{ | |||
"IstioOperator": "istio/operator:1.12.2@sha256:42c7609872882cb88728a1592561b4046dac6d05b6002cbdc815b84c86a24f08", | |||
"IstioOperator": "istio/operator:1.18.1@sha256:86929072495a0c8128802587208780649d61394167579eea02786d91090d0c66", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I pull the image I get a different SHA than you have listed
docker pull istio/operator:1.18.1
1.18.1: Pulling from istio/operator
c39e4b8c44d6: Pull complete
ec96bb23360c: Pull complete
4658f4a514c5: Pull complete
28d661d108f2: Pull complete
434155d50110: Pull complete
Digest: sha256:9ae5aa7508374da4c8052389c2aef521ba360ee7bc54f5e1480b7fe4b33c6e48
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried it myself, it seems like the have 2 checksums for the the same image
but dockerhub only shows one,
https://hub.docker.com/layers/istio/operator/1.18.1/images/sha256-86929072495a0c8128802587208780649d61394167579eea02786d91090d0c66?context=explore
docker pull istio/operator:1.18.1@sha256:86929072495a0c8128802587208780649d61394167579eea02786d91090d0c66
docker pull istio/operator:1.18.1
docker inspect istio/operator:1.18.1
from version 1.12.2 -> 1.18.1