Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Istio Operator #16905

Closed
wants to merge 1 commit into from
Closed

Update Istio Operator #16905

wants to merge 1 commit into from

Conversation

rschoebel
Copy link

from version 1.12.2 -> 1.18.1

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 18, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rschoebel
Once this PR has been reviewed and has the lgtm label, please assign medyagh for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Welcome @rschoebel!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 18, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @rschoebel. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 18, 2023
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 18, 2023
@spowelljr
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 18, 2023
@minikube-pr-bot

This comment has been minimized.

Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rschoebel do u mind posting Before/After this PR output to ensure this is not breaking ?

@minikube-pr-bot

This comment has been minimized.

@rschoebel
Copy link
Author

Screenshot from 2023-07-19 04-26-52

i hope this is enough

@rschoebel rschoebel requested a review from medyagh August 2, 2023 06:23
@spowelljr
Copy link
Member

/retest-this-please

@minikube-pr-bot

This comment has been minimized.

@minikube-pr-bot

This comment has been minimized.

from version 1.12.1 -> 1.18.1
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 16905) |
+----------------+----------+---------------------+
| minikube start | 51.0s    | 51.6s               |
| enable ingress | 28.2s    | 28.0s               |
+----------------+----------+---------------------+

Times for minikube start: 52.4s 50.9s 48.9s 51.8s 51.0s
Times for minikube (PR 16905) start: 52.9s 51.5s 52.7s 49.8s 51.4s

Times for minikube ingress: 28.6s 27.6s 28.1s 28.3s 28.1s
Times for minikube (PR 16905) ingress: 25.2s 28.2s 29.2s 28.7s 28.7s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 16905) |
+----------------+----------+---------------------+
| minikube start | 23.8s    | 24.1s               |
| enable ingress | 20.8s    | 21.5s               |
+----------------+----------+---------------------+

Times for minikube start: 22.7s 21.5s 22.6s 27.1s 25.0s
Times for minikube (PR 16905) start: 25.2s 25.0s 24.2s 23.8s 22.5s

Times for minikube ingress: 20.8s 19.8s 20.8s 21.8s 20.9s
Times for minikube (PR 16905) ingress: 21.9s 20.8s 21.9s 21.9s 20.9s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 16905) |
+----------------+----------+---------------------+
| minikube start | 22.0s    | 23.0s               |
| enable ingress | 31.1s    | 31.3s               |
+----------------+----------+---------------------+

Times for minikube (PR 16905) start: 23.4s 22.8s 21.2s 23.6s 23.9s
Times for minikube start: 23.2s 21.5s 20.8s 23.1s 21.5s

Times for minikube ingress: 31.3s 31.3s 31.3s 31.3s 30.3s
Times for minikube (PR 16905) ingress: 31.3s 31.3s 31.3s 31.4s 31.3s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
KVM_Linux TestFunctional/parallel/MountCmd/specific-port (gopogh) 1.69 (chart)

To see the flake rates of all tests by environment, click here.

@@ -275,7 +275,7 @@ var Addons = map[string]*Addon{
"istio-operator.yaml",
"0640"),
}, false, "istio-provisioner", "3rd party (Istio)", "", "https://istio.io/latest/docs/setup/platform-setup/minikube/", map[string]string{
"IstioOperator": "istio/operator:1.12.2@sha256:42c7609872882cb88728a1592561b4046dac6d05b6002cbdc815b84c86a24f08",
"IstioOperator": "istio/operator:1.18.1@sha256:86929072495a0c8128802587208780649d61394167579eea02786d91090d0c66",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I pull the image I get a different SHA than you have listed

docker pull istio/operator:1.18.1
1.18.1: Pulling from istio/operator
c39e4b8c44d6: Pull complete 
ec96bb23360c: Pull complete 
4658f4a514c5: Pull complete 
28d661d108f2: Pull complete 
434155d50110: Pull complete 
Digest: sha256:9ae5aa7508374da4c8052389c2aef521ba360ee7bc54f5e1480b7fe4b33c6e48

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried it myself, it seems like the have 2 checksums for the the same image

but dockerhub only shows one,
https://hub.docker.com/layers/istio/operator/1.18.1/images/sha256-86929072495a0c8128802587208780649d61394167579eea02786d91090d0c66?context=explore

docker pull istio/operator:1.18.1@sha256:86929072495a0c8128802587208780649d61394167579eea02786d91090d0c66
docker pull istio/operator:1.18.1
docker inspect istio/operator:1.18.1

@rschoebel rschoebel closed this Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants