Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installing step should have docker user and group creation step as well #19742

Closed
niharika1233 opened this issue Oct 2, 2024 · 8 comments · Fixed by #19925
Closed

Installing step should have docker user and group creation step as well #19742

niharika1233 opened this issue Oct 2, 2024 · 8 comments · Fixed by #19925
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/documentation Categorizes issue or PR as related to documentation.

Comments

@niharika1233
Copy link

What Happened?

I was installing minikube and found that running minikube installation needs docker as a user and in group as well.

Attach the log file

no such file for logs

Operating System

Ubuntu

Driver

Docker

@spowelljr
Copy link
Member

Hi @niharika1233, could you explain exactly what you mean. What command did you run? What error were you getting?

@spowelljr spowelljr added kind/support Categorizes issue or PR as a support question. triage/needs-information Indicates an issue needs more information in order to work on it. labels Oct 2, 2024
@niharika1233
Copy link
Author

@spowelljr yes sir, let me just try to recreate the issue

@niharika1233
Copy link
Author

Sir while running minikube, i found an error saying that i should not run docker as root, which required me to first add a group docker and then add a user to that docker group for the part of installation of minikube. We should either do two things 1> add a prerequisite to confirm user as docker and not root user 2> or the required steps for the docker

@spowelljr
Copy link
Member

Adding a docker group and adding the user is part of the Docker install instructions: https://docs.docker.com/engine/install/linux-postinstall/#manage-docker-as-a-non-root-user

@niharika1233
Copy link
Author

image

Please see above image, instead I am going to run it as root now.

image

Now to get rid of these errors i need to follow the steps for docker, now I believe at least we should tell people with a small link there and make docker user as prerequisite.

@spowelljr
Copy link
Member

I'm not sure I understand what you're trying to suggest. Completely unrelated to minikube, when you install docker there are instructions to add your user to the docker group, as seen in https://docs.docker.com/engine/install/linux-postinstall/#manage-docker-as-a-non-root-user. It seems you accidentally missed that step, which is fine, and then when you try to start minikube we see that you forgot that step and output the following:

docker: Suggestion: Add your user to the 'docker' group: 'sudo usermod -aG docker $USER && newgrp docker' <https://docs.docker.com/engine/install/linux-postinstall/>

If you run the command we provided you it should resolve your issue, we don't support running minikube as root with the docker driver.

I believe at least we should tell people with a small link there and make docker user as prerequisite

That's what the suggestion is telling your to do already.

@niharika1233
Copy link
Author

The suggestion that you are giving on command line thanks for that, i think you can also include as prerequisites steps in the installation webpage

@spowelljr spowelljr added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/documentation Categorizes issue or PR as related to documentation. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. and removed triage/needs-information Indicates an issue needs more information in order to work on it. kind/support Categorizes issue or PR as a support question. labels Oct 30, 2024
@LuBingtan
Copy link
Contributor

Not sure if this PR #19925 can address the issue. @spowelljr PTAL
/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/documentation Categorizes issue or PR as related to documentation.
Projects
None yet
3 participants