Skip to content

Commit

Permalink
Merge pull request #17671 from prezha/fix-containerd-ImageExists
Browse files Browse the repository at this point in the history
fix containerd ImageExists to look for image name and image id sha
  • Loading branch information
medyagh authored Nov 28, 2023
2 parents 638da15 + 199a0e3 commit bfffdb9
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions pkg/minikube/cruntime/containerd.go
Original file line number Diff line number Diff line change
Expand Up @@ -248,12 +248,12 @@ func (r *Containerd) Disable() error {

// ImageExists checks if image exists based on image name and optionally image sha
func (r *Containerd) ImageExists(name string, sha string) bool {
c := exec.Command("/bin/bash", "-c", fmt.Sprintf("sudo ctr -n=k8s.io images check | grep %s", name))
rr, err := r.Runner.RunCmd(c)
if err != nil {
return false
}
if sha != "" && !strings.Contains(rr.Output(), sha) {
klog.Infof("Checking existence of image with name %q and sha %q", name, sha)
c := exec.Command("sudo", "ctr", "-n=k8s.io", "images", "check")
// note: image name and image id's sha can be on different lines in ctr output
if rr, err := r.Runner.RunCmd(c); err != nil ||
!strings.Contains(rr.Output(), name) ||
(sha != "" && !strings.Contains(rr.Output(), sha)) {
return false
}
return true
Expand Down

0 comments on commit bfffdb9

Please sign in to comment.