Skip to content

Commit

Permalink
Fix long lines in lastStart.txt not outputting in log outputs (#19740)
Browse files Browse the repository at this point in the history
  • Loading branch information
spowelljr authored Oct 2, 2024
1 parent 746051d commit 9d3094c
Showing 1 changed file with 12 additions and 6 deletions.
18 changes: 12 additions & 6 deletions pkg/minikube/logs/logs.go
Original file line number Diff line number Diff line change
Expand Up @@ -234,15 +234,21 @@ func OutputLastStart() error {
}
defer f.Close()
l := ""
s := bufio.NewScanner(f)
for s.Scan() {
l += s.Text() + "\n"
r := bufio.NewReader(f)
var s string
for {
s, err = r.ReadString('\n')
if err != nil {
break
}
l += s
}
out.Styled(style.None, l)
if err := s.Err(); err != nil {
return fmt.Errorf("failed to read file %s: %v", fp, err)
if err == io.EOF {
return nil
}
return nil

return fmt.Errorf("failed to read file %s: %v", fp, err)
}

// OutputOffline outputs logs that don't need a running cluster.
Expand Down

0 comments on commit 9d3094c

Please sign in to comment.