Skip to content

Commit

Permalink
Addon inspektor-gadget: Update inspektor-gadget image from v0.22.0 to…
Browse files Browse the repository at this point in the history
… v0.23.1

This commit bumps Inspektor Gadget addon from v0.22.0 to v0.23.1.
To avoid deployment failures, we also need to update the YAML.

Indeed, Inspektor Gadget container entrypoint and cleanup programs were
translated from bash to golang [1, 2].
Upstream YAML file used to deploy was updated to reflect this change [3].

Sadly, it was not the case for the YAML used to deploy the minikube addon which
leaded to troubles [4, 5, 6].

Signed-off-by: Francis Laniel <[email protected]>
[1]: inspektor-gadget/inspektor-gadget@b268d38
[2]: inspektor-gadget/inspektor-gadget@3dba83f
[3]: inspektor-gadget/inspektor-gadget@992399f#diff-0927404b80a3c13f63de64a0c7af1833ba3dfd4b4e1dd07b09cb8216c7f033fcR46
[4]: https://storage.googleapis.com/minikube-builds/logs/17731/32161/Docker_Linux_crio_arm64.html#fail_TestAddons/parallel/InspektorGadget
[5]: https://storage.googleapis.com/minikube-builds/logs/17731/32161/Docker_Linux_crio.html#fail_TestAddons/parallel/InspektorGadget
[6]: https://storage.googleapis.com/minikube-builds/logs/17731/32161/KVM_Linux_crio.html#fail_TestAddons/parallel/InspektorGadget
  • Loading branch information
eiffel-fl committed Dec 6, 2023
1 parent c56894f commit 6db73b2
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions deploy/addons/inspektor-gadget/ig-daemonset.yaml.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,12 @@ spec:
terminationMessagePolicy: FallbackToLogsOnError
image: {{.CustomRegistries.InspektorGadget | default .ImageRepository | default .Registries.InspektorGadget }}{{.Images.InspektorGadget}}
imagePullPolicy: "Always"
command: [ "/entrypoint.sh" ]
command: [ "/entrypoint" ]
lifecycle:
preStop:
exec:
command:
- "/cleanup.sh"
- "/cleanup"
readinessProbe:
periodSeconds: 5
timeoutSeconds: 2
Expand Down
2 changes: 1 addition & 1 deletion pkg/minikube/assets/addons.go
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,7 @@ var Addons = map[string]*Addon{
MustBinAsset(addons.InspektorGadgetAssets, "inspektor-gadget/ig-daemonset.yaml.tmpl", vmpath.GuestAddonsDir, "ig-daemonset.yaml", "0640"),
}, false, "inspektor-gadget", "3rd party (inspektor-gadget.io)", "https://github.com/orgs/inspektor-gadget/people", "https://minikube.sigs.k8s.io/docs/handbook/addons/inspektor-gadget/",
map[string]string{
"InspektorGadget": "inspektor-gadget/inspektor-gadget:v0.22.0@sha256:9272c2be979a9857971fc8b6f7226e609cadec8352f97e9769081930121ef27f",
"InspektorGadget": "inspektor-gadget/inspektor-gadget:v0.23.1@sha256:c77d8eb2b3dc6e9d60767f824b296e42d6d4fdc2f17f507492a2c981933db931",
}, map[string]string{
"InspektorGadget": "ghcr.io",
}),
Expand Down

0 comments on commit 6db73b2

Please sign in to comment.