Skip to content

Commit

Permalink
No more arch restriction on nerdctld
Browse files Browse the repository at this point in the history
Since the release of version 0.6.0
  • Loading branch information
afbjorklund committed Sep 29, 2024
1 parent c50fe68 commit 6b0d3c6
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions cmd/minikube/cmd/docker-env.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ import (
"net/url"
"os"
"os/exec"
"runtime"
"strconv"
"strings"
"time"
Expand Down Expand Up @@ -309,7 +308,6 @@ docker-cli install instructions: https://minikube.sigs.k8s.io/docs/tutorials/doc
exit.Message(reason.EnvMultiConflict, `The docker-env command is incompatible with multi-node clusters. Use the 'registry' add-on: https://minikube.sigs.k8s.io/docs/handbook/registry/`)
}
cr := co.Config.KubernetesConfig.ContainerRuntime
// nerdctld supports amd64 and arm64
if err := dockerEnvSupported(cr, driverName); err != nil {
exit.Message(reason.Usage, err.Error())
}
Expand Down Expand Up @@ -674,9 +672,6 @@ func tryDockerConnectivity(bin string, ec DockerEnvConfig) ([]byte, error) {
}

func dockerEnvSupported(containerRuntime, driverName string) error {
if runtime.GOARCH != "amd64" && runtime.GOARCH != "arm64" {
return fmt.Errorf("the docker-env command only supports amd64 & arm64 architectures")
}
if containerRuntime != constants.Docker && containerRuntime != constants.Containerd {
return fmt.Errorf("the docker-env command only supports the docker and containerd runtimes")
}
Expand Down

0 comments on commit 6b0d3c6

Please sign in to comment.