Merge pull request #18142 from minikube-bot/auto_bump_golint_version

CI: Update golint from v1.55.2 to v1.56.1

Makefile

@@ -79,7 +79,7 @@ MINIKUBE_RELEASES_URL=https://github.com/kubernetes/minikube/releases/download
 KERNEL_VERSION ?= 5.10.57
 # latest from https://github.com/golangci/golangci-lint/releases
 # update this only by running `make update-golint-version`
-GOLINT_VERSION ?= v1.55.2
+GOLINT_VERSION ?= v1.56.1
 # Limit number of default jobs, to avoid the CI builds running out of memory
 GOLINT_JOBS ?= 4
 # see https://github.com/golangci/golangci-lint#memory-usage-of-golangci-lint

cmd/minikube/cmd/cache.go

@@ -47,7 +47,7 @@ var addCacheCmd = &cobra.Command{
 	Use:   "add",
 	Short: "Add an image to local cache.",
 	Long:  "Add an image to local cache.",
-	Run: func(cmd *cobra.Command, args []string) {
+	Run: func(_ *cobra.Command, args []string) {
 		out.WarningT("\"minikube cache\" will be deprecated in upcoming versions, please switch to \"minikube image load\"")
 		// Cache and load images into docker daemon
 		if err := machine.CacheAndLoadImages(args, cacheAddProfiles(), false); err != nil {
@@ -85,7 +85,7 @@ var deleteCacheCmd = &cobra.Command{
 	Use:   "delete",
 	Short: "Delete an image from the local cache.",
 	Long:  "Delete an image from the local cache.",
-	Run: func(cmd *cobra.Command, args []string) {
+	Run: func(_ *cobra.Command, args []string) {
 		// Delete images from config file
 		if err := cmdConfig.DeleteFromConfigMap(cacheImageConfigKey, args); err != nil {
 			exit.Error(reason.InternalDelConfig, "Failed to delete images from config", err)
@@ -102,7 +102,7 @@ var reloadCacheCmd = &cobra.Command{
 	Use:   "reload",
 	Short: "reload cached images.",
 	Long:  "reloads images previously added using the 'cache add' subcommand",
-	Run: func(cmd *cobra.Command, args []string) {
+	Run: func(_ *cobra.Command, _ []string) {
 		err := node.CacheAndLoadImagesInConfig(cacheAddProfiles())
 		if err != nil {
 			exit.Error(reason.GuestCacheLoad, "Failed to reload cached images", err)

cmd/minikube/cmd/cache_list.go

@@ -40,7 +40,7 @@ var listCacheCmd = &cobra.Command{
 	Use:   "list",
 	Short: "List all available images from the local cache.",
 	Long:  "List all available images from the local cache.",
-	Run: func(cmd *cobra.Command, args []string) {
+	Run: func(_ *cobra.Command, _ []string) {
 		images, err := cmdConfig.ListConfigMap(cacheImageConfigKey)
 		if err != nil {
 			exit.Error(reason.InternalListConfig, "Failed to get image map", err)

cmd/minikube/cmd/completion.go

@@ -81,7 +81,7 @@ var completionCmd = &cobra.Command{
 	Use:   "completion SHELL",
 	Short: "Generate command completion for a shell",
 	Long:  longDescription,
-	Run: func(cmd *cobra.Command, args []string) {
+	Run: func(_ *cobra.Command, args []string) {
 		if len(args) != 1 {
 			exit.Message(reason.Usage, "Usage: minikube completion SHELL")
 		}
@@ -95,7 +95,7 @@ var bashCmd = &cobra.Command{
 	Use:   "bash",
 	Short: "bash completion.",
 	Long:  "Generate command completion for bash.",
-	Run: func(cmd *cobra.Command, args []string) {
+	Run: func(cmd *cobra.Command, _ []string) {
 		err := GenerateBashCompletion(os.Stdout, cmd.Root())
 		if err != nil {
 			exit.Error(reason.InternalCompletion, "bash completion failed", err)
@@ -107,7 +107,7 @@ var zshCmd = &cobra.Command{
 	Use:   "zsh",
 	Short: "zsh completion.",
 	Long:  "Generate command completion for zsh.",
-	Run: func(cmd *cobra.Command, args []string) {
+	Run: func(cmd *cobra.Command, _ []string) {
 		err := GenerateZshCompletion(os.Stdout, cmd.Root())
 		if err != nil {
 			exit.Error(reason.InternalCompletion, "zsh completion failed", err)
@@ -119,7 +119,7 @@ var fishCmd = &cobra.Command{
 	Use:   "fish",
 	Short: "fish completion.",
 	Long:  "Generate command completion for fish .",
-	Run: func(cmd *cobra.Command, args []string) {
+	Run: func(cmd *cobra.Command, _ []string) {
 		err := GenerateFishCompletion(os.Stdout, cmd.Root())
 		if err != nil {
 			exit.Error(reason.InternalCompletion, "fish completion failed", err)
@@ -131,7 +131,7 @@ var powershellCmd = &cobra.Command{
 	Use:   "powershell",
 	Short: "powershell completion.",
 	Long:  "Generate command completion for PowerShell.",
-	Run: func(cmd *cobra.Command, args []string) {
+	Run: func(cmd *cobra.Command, _ []string) {
 		err := GeneratePowerShellCompletion(os.Stdout, cmd.Root())
 		if err != nil {
 			exit.Error(reason.InternalCompletion, "powershell completion failed", err)

cmd/minikube/cmd/config/addons.go

@@ -27,7 +27,7 @@ var AddonsCmd = &cobra.Command{
 	Use:   "addons SUBCOMMAND [flags]",
 	Short: "Enable or disable a minikube addon",
 	Long:  `addons modifies minikube addons files using subcommands like "minikube addons enable dashboard"`,
-	Run: func(cmd *cobra.Command, args []string) {
+	Run: func(cmd *cobra.Command, _ []string) {
 		if err := cmd.Help(); err != nil {
 			klog.Errorf("help: %v", err)
 		}

cmd/minikube/cmd/config/addons_list.go

@@ -48,7 +48,7 @@ var addonsListCmd = &cobra.Command{
 	Use:   "list",
 	Short: "Lists all available minikube addons as well as their current statuses (enabled/disabled)",
 	Long:  "Lists all available minikube addons as well as their current statuses (enabled/disabled)",
-	Run: func(cmd *cobra.Command, args []string) {
+	Run: func(_ *cobra.Command, args []string) {
 		if len(args) != 0 {
 			exit.Message(reason.Usage, "usage: minikube addons list")
 		}

cmd/minikube/cmd/config/config.go

@@ -180,7 +180,7 @@ var ConfigCmd = &cobra.Command{
 	Short: "Modify persistent configuration values",
 	Long: `config modifies minikube config files using subcommands like "minikube config set driver kvm2"
 Configurable fields: ` + "\n\n" + configurableFields(),
-	Run: func(cmd *cobra.Command, args []string) {
+	Run: func(cmd *cobra.Command, _ []string) {
 		if err := cmd.Help(); err != nil {
 			klog.ErrorS(err, "help")
 		}

cmd/minikube/cmd/config/configure.go

@@ -40,7 +40,7 @@ var addonsConfigureCmd = &cobra.Command{
 	Use:   "configure ADDON_NAME",
 	Short: "Configures the addon w/ADDON_NAME within minikube (example: minikube addons configure registry-creds). For a list of available addons use: minikube addons list",
 	Long:  "Configures the addon w/ADDON_NAME within minikube (example: minikube addons configure registry-creds). For a list of available addons use: minikube addons list",
-	Run: func(cmd *cobra.Command, args []string) {
+	Run: func(_ *cobra.Command, args []string) {
 		if len(args) != 1 {
 			exit.Message(reason.Usage, "usage: minikube addons configure ADDON_NAME")
 		}

cmd/minikube/cmd/config/disable.go

@@ -31,7 +31,7 @@ var addonsDisableCmd = &cobra.Command{
 	Use:   "disable ADDON_NAME",
 	Short: "Disables the addon w/ADDON_NAME within minikube (example: minikube addons disable dashboard). For a list of available addons use: minikube addons list ",
 	Long:  "Disables the addon w/ADDON_NAME within minikube (example: minikube addons disable dashboard). For a list of available addons use: minikube addons list ",
-	Run: func(cmd *cobra.Command, args []string) {
+	Run: func(_ *cobra.Command, args []string) {
 		if len(args) != 1 {
 			exit.Message(reason.Usage, "usage: minikube addons disable ADDON_NAME")
 		}

cmd/minikube/cmd/config/enable.go

@@ -37,7 +37,7 @@ var addonsEnableCmd = &cobra.Command{
 	Short:   "Enables the addon w/ADDON_NAME within minikube. For a list of available addons use: minikube addons list ",
 	Long:    "Enables the addon w/ADDON_NAME within minikube. For a list of available addons use: minikube addons list ",
 	Example: "minikube addons enable dashboard",
-	Run: func(cmd *cobra.Command, args []string) {
+	Run: func(_ *cobra.Command, args []string) {
 		if len(args) != 1 {
 			exit.Message(reason.Usage, "usage: minikube addons enable ADDON_NAME")
 		}

cmd/minikube/cmd/config/images.go

@@ -32,7 +32,7 @@ var addonsImagesCmd = &cobra.Command{
 	Short:   "List image names the addon w/ADDON_NAME used. For a list of available addons use: minikube addons list",
 	Long:    "List image names the addon w/ADDON_NAME used. For a list of available addons use: minikube addons list",
 	Example: "minikube addons images ingress",
-	Run: func(cmd *cobra.Command, args []string) {
+	Run: func(_ *cobra.Command, args []string) {
 		if len(args) != 1 {
 			exit.Message(reason.Usage, "usage: minikube addons images ADDON_NAME")
 		}

cmd/minikube/cmd/config/open.go

@@ -46,14 +46,14 @@ var addonsOpenCmd = &cobra.Command{
 	Use:   "open ADDON_NAME",
 	Short: "Opens the addon w/ADDON_NAME within minikube (example: minikube addons open dashboard). For a list of available addons use: minikube addons list ",
 	Long:  "Opens the addon w/ADDON_NAME within minikube (example: minikube addons open dashboard). For a list of available addons use: minikube addons list ",
-	PreRun: func(cmd *cobra.Command, args []string) {
+	PreRun: func(_ *cobra.Command, _ []string) {
 		t, err := template.New("addonsURL").Parse(addonsURLFormat)
 		if err != nil {
 			exit.Message(reason.Usage, "The value passed to --format is invalid: {{.error}}", out.V{"error": err})
 		}
 		addonsURLTemplate = t
 	},
-	Run: func(cmd *cobra.Command, args []string) {
+	Run: func(_ *cobra.Command, args []string) {
 		if len(args) != 1 {
 			exit.Message(reason.Usage, "usage: minikube addons open ADDON_NAME")
 		}

cmd/minikube/cmd/config/profile.go

@@ -34,7 +34,7 @@ var ProfileCmd = &cobra.Command{
 	Use:   "profile [MINIKUBE_PROFILE_NAME].  You can return to the default minikube profile by running `minikube profile default`",
 	Short: "Get or list the current profiles (clusters)",
 	Long:  "profile sets the current minikube profile, or gets the current profile if no arguments are provided.  This is used to run and manage multiple minikube instance.  You can return to the default minikube profile by running `minikube profile default`",
-	Run: func(cmd *cobra.Command, args []string) {
+	Run: func(_ *cobra.Command, args []string) {
 		if len(args) == 0 {
 			profile := ClusterFlagValue()
 			out.Styled(style.Empty, profile)

cmd/minikube/cmd/config/profile_list.go

@@ -49,7 +49,7 @@ var profileListCmd = &cobra.Command{
 	Use:   "list",
 	Short: "Lists all minikube profiles.",
 	Long:  "Lists all valid minikube profiles and detects all possible invalid profiles.",
-	Run: func(cmd *cobra.Command, args []string) {
+	Run: func(_ *cobra.Command, _ []string) {
 		output := strings.ToLower(profileOutput)
 		out.SetJSON(output == "json")
 		go notify.MaybePrintUpdateTextFromGithub()

cmd/minikube/cmd/config/set.go

@@ -31,7 +31,7 @@ var configSetCmd = &cobra.Command{
 	Short: "Sets an individual value in a minikube config file",
 	Long: `Sets the PROPERTY_NAME config value to PROPERTY_VALUE
 	These values can be overwritten by flags or environment variables at runtime.`,
-	Run: func(cmd *cobra.Command, args []string) {
+	Run: func(_ *cobra.Command, args []string) {
 		if len(args) < 2 {
 			exit.Message(reason.Usage, "not enough arguments ({{.ArgCount}}).\nusage: minikube config set PROPERTY_NAME PROPERTY_VALUE", out.V{"ArgCount": len(args)})
 		}

cmd/minikube/cmd/config/unset.go

@@ -28,7 +28,7 @@ var configUnsetCmd = &cobra.Command{
 	Use:   "unset PROPERTY_NAME",
 	Short: "unsets an individual value in a minikube config file",
 	Long:  "unsets PROPERTY_NAME from the minikube config file.  Can be overwritten by flags or environmental variables",
-	Run: func(cmd *cobra.Command, args []string) {
+	Run: func(_ *cobra.Command, args []string) {
 		if len(args) != 1 {
 			exit.Message(reason.Usage, "usage: minikube config unset PROPERTY_NAME")
 		}

cmd/minikube/cmd/config/view.go

@@ -41,7 +41,7 @@ var configViewCmd = &cobra.Command{
 	Use:   "view",
 	Short: "Display values currently set in the minikube config file",
 	Long:  "Display values currently set in the minikube config file.",
-	Run: func(cmd *cobra.Command, args []string) {
+	Run: func(_ *cobra.Command, _ []string) {
 		err := View()
 		if err != nil {
 			exit.Error(reason.InternalConfigView, "config view failed", err)

cmd/minikube/cmd/cp.go

@@ -52,7 +52,7 @@ Default target node controlplane and If <source node name> is omitted, It will t
 Example Command : "minikube cp a.txt /home/docker/b.txt" +
                   "minikube cp a.txt minikube-m02:/home/docker/b.txt"
                   "minikube cp minikube-m01:a.txt minikube-m02:/home/docker/b.txt"`,
-	Run: func(cmd *cobra.Command, args []string) {
+	Run: func(_ *cobra.Command, args []string) {
 		if len(args) != 2 {
 			exit.Message(reason.Usage, `Please specify the path to copy: 
 	minikube cp <source file path> <target file absolute path> (example: "minikube cp a/b.txt /copied.txt")`)

cmd/minikube/cmd/dashboard.go

@@ -57,7 +57,7 @@ var dashboardCmd = &cobra.Command{
 	Use:   "dashboard",
 	Short: "Access the Kubernetes dashboard running within the minikube cluster",
 	Long:  `Access the Kubernetes dashboard running within the minikube cluster`,
-	Run: func(cmd *cobra.Command, args []string) {
+	Run: func(_ *cobra.Command, _ []string) {
 		cname := ClusterFlagValue()
 		co := mustload.Healthy(cname)
 

cmd/minikube/cmd/delete_test.go

@@ -145,9 +145,7 @@ func TestDeleteProfile(t *testing.T) {
 	}
 }
 
-var hostAndDirsDeleterMock = func(api libmachine.API, cc *config.ClusterConfig, profileName string) error {
-	return deleteContextTest()
-}
+var hostAndDirsDeleterMock = func(_ libmachine.API, _ *config.ClusterConfig, _ string) error { return deleteContextTest() }
 
 func deleteContextTest() error {
 	if err := cmdcfg.Unset(config.ProfileName); err != nil {

cmd/minikube/cmd/docker-env.go

@@ -270,7 +270,7 @@ For example, you can do all docker operations such as docker build, docker run,
 
 Note: You need the docker-cli to be installed on your machine.
 docker-cli install instructions: https://minikube.sigs.k8s.io/docs/tutorials/docker_desktop_replacement/#steps`,
-	Run: func(cmd *cobra.Command, args []string) {
+	Run: func(_ *cobra.Command, _ []string) {
 		var err error
 
 		shl := shell.ForceShell

cmd/minikube/cmd/generate-docs.go

@@ -38,7 +38,7 @@ var generateDocs = &cobra.Command{
 	Long:    "Populates the specified folder with documentation in markdown about minikube",
 	Example: "minikube generate-docs --path <FOLDER_PATH>",
 	Hidden:  true,
-	Run: func(cmd *cobra.Command, args []string) {
+	Run: func(_ *cobra.Command, _ []string) {
 		// if directory does not exist
 		st, err := os.Stat(docsPath)
 		if err != nil || !st.IsDir() {

cmd/minikube/cmd/image.go

@@ -80,7 +80,7 @@ var loadImageCmd = &cobra.Command{
 	Short:   "Load an image into minikube",
 	Long:    "Load an image into minikube",
 	Example: "minikube image load image\nminikube image load image.tar",
-	Run: func(cmd *cobra.Command, args []string) {
+	Run: func(_ *cobra.Command, args []string) {
 		if len(args) == 0 {
 			exit.Message(reason.Usage, "Please provide an image in your local daemon to load into minikube via <minikube image load IMAGE_NAME>")
 		}
@@ -171,7 +171,7 @@ var saveImageCmd = &cobra.Command{
 	Short:   "Save a image from minikube",
 	Long:    "Save a image from minikube",
 	Example: "minikube image save image\nminikube image save image image.tar",
-	Run: func(cmd *cobra.Command, args []string) {
+	Run: func(_ *cobra.Command, args []string) {
 		if len(args) == 0 {
 			exit.Message(reason.Usage, "Please provide an image in the container runtime to save from minikube via <minikube image save IMAGE_NAME>")
 		}
@@ -230,7 +230,7 @@ $ minikube image unload image busybox
 `,
 	Args:    cobra.MinimumNArgs(1),
 	Aliases: []string{"remove", "unload"},
-	Run: func(cmd *cobra.Command, args []string) {
+	Run: func(_ *cobra.Command, args []string) {
 		profile, err := config.LoadProfile(viper.GetString(config.ProfileName))
 		if err != nil {
 			exit.Error(reason.Usage, "loading profile", err)
@@ -247,7 +247,7 @@ var pullImageCmd = &cobra.Command{
 	Example: `
 $ minikube image pull busybox
 `,
-	Run: func(cmd *cobra.Command, args []string) {
+	Run: func(_ *cobra.Command, args []string) {
 		profile, err := config.LoadProfile(viper.GetString(config.ProfileName))
 		if err != nil {
 			exit.Error(reason.Usage, "loading profile", err)
@@ -273,7 +273,7 @@ var buildImageCmd = &cobra.Command{
 	Short:   "Build a container image in minikube",
 	Long:    "Build a container image, using the container runtime.",
 	Example: `minikube image build .`,
-	Run: func(cmd *cobra.Command, args []string) {
+	Run: func(_ *cobra.Command, args []string) {
 		if len(args) < 1 {
 			exit.Message(reason.Usage, "Please provide a path or url to build")
 		}
@@ -333,7 +333,7 @@ var listImageCmd = &cobra.Command{
 $ minikube image ls
 `,
 	Aliases: []string{"list"},
-	Run: func(cmd *cobra.Command, args []string) {
+	Run: func(_ *cobra.Command, _ []string) {
 		profile, err := config.LoadProfile(viper.GetString(config.ProfileName))
 		if err != nil {
 			exit.Error(reason.Usage, "loading profile", err)
@@ -352,7 +352,7 @@ var tagImageCmd = &cobra.Command{
 $ minikube image tag source target
 `,
 	Aliases: []string{"list"},
-	Run: func(cmd *cobra.Command, args []string) {
+	Run: func(_ *cobra.Command, args []string) {
 		if len(args) != 2 {
 			exit.Message(reason.Usage, "Please provide source and target image")
 		}
@@ -373,7 +373,7 @@ var pushImageCmd = &cobra.Command{
 	Example: `
 $ minikube image push busybox
 `,
-	Run: func(cmd *cobra.Command, args []string) {
+	Run: func(_ *cobra.Command, args []string) {
 		profile, err := config.LoadProfile(viper.GetString(config.ProfileName))
 		if err != nil {
 			exit.Error(reason.Usage, "loading profile", err)

cmd/minikube/cmd/ip.go

@@ -30,7 +30,7 @@ var ipCmd = &cobra.Command{
 	Use:   "ip",
 	Short: "Retrieves the IP address of the specified node",
 	Long:  `Retrieves the IP address of the specified node, and writes it to STDOUT.`,
-	Run: func(cmd *cobra.Command, args []string) {
+	Run: func(_ *cobra.Command, _ []string) {
 		co := mustload.Running(ClusterFlagValue())
 		n, _, err := node.Retrieve(*co.Config, nodeName)
 		if err != nil {

cmd/minikube/cmd/kubectl.go

@@ -53,7 +53,7 @@ but optionally you can also run it directly on the control plane over the ssh co
 This can be useful if you cannot run kubectl locally for some reason, like unsupported
 host. Please be aware that when using --ssh all paths will apply to the remote machine.`,
 	Example: "minikube kubectl -- --help\nminikube kubectl -- get pods --namespace kube-system",
-	Run: func(cmd *cobra.Command, args []string) {
+	Run: func(_ *cobra.Command, args []string) {
 		cc, err := config.Load(ClusterFlagValue())
 
 		version := constants.DefaultKubernetesVersion

cmd/minikube/cmd/license.go

@@ -30,7 +30,7 @@ var licenseCmd = &cobra.Command{
 	Use:   "license",
 	Short: "Outputs the licenses of dependencies to a directory",
 	Long:  "Outputs the licenses of dependencies to a directory",
-	Run: func(cmd *cobra.Command, args []string) {
+	Run: func(_ *cobra.Command, _ []string) {
 		if err := download.Licenses(dir); err != nil {
 			exit.Error(reason.InetLicenses, "Failed to download licenses", err)
 		}

cmd/minikube/cmd/logs.go

@@ -62,7 +62,7 @@ var logsCmd = &cobra.Command{
 	Use:   "logs",
 	Short: "Returns logs to debug a local Kubernetes cluster",
 	Long:  `Gets the logs of the running instance, used for debugging minikube, not user code.`,
-	Run: func(cmd *cobra.Command, args []string) {
+	Run: func(_ *cobra.Command, _ []string) {
 		var logOutput *os.File = os.Stdout
 		var err error
 

cmd/minikube/cmd/mount.go

@@ -91,7 +91,7 @@ var mountCmd = &cobra.Command{
 	Use:   "mount [flags] <source directory>:<target directory>",
 	Short: "Mounts the specified directory into minikube",
 	Long:  `Mounts the specified directory into minikube.`,
-	Run: func(cmd *cobra.Command, args []string) {
+	Run: func(_ *cobra.Command, args []string) {
 		if isKill {
 			if err := killMountProcess(); err != nil {
 				exit.Error(reason.HostKillMountProc, "Error killing mount process", err)

cmd/minikube/cmd/node.go

@@ -27,7 +27,7 @@ var nodeCmd = &cobra.Command{
 	Use:   "node",
 	Short: "Add, remove, or list additional nodes",
 	Long:  "Operations on nodes",
-	Run: func(cmd *cobra.Command, args []string) {
+	Run: func(_ *cobra.Command, _ []string) {
 		exit.Message(reason.Usage, "Usage: minikube node [add|start|stop|delete|list]")
 	},
 }

cmd/minikube/cmd/node_add.go

@@ -40,7 +40,7 @@ var nodeAddCmd = &cobra.Command{
 	Use:   "add",
 	Short: "Adds a node to the given cluster.",
 	Long:  "Adds a node to the given cluster config, and starts it.",
-	Run: func(cmd *cobra.Command, args []string) {
+	Run: func(cmd *cobra.Command, _ []string) {
 		co := mustload.Healthy(ClusterFlagValue())
 		cc := co.Config