Merge pull request #15585 from rogeriomm/master-fix-registry

Fix addon registry doesn't follow Minikube DNS domain name configuration (--dns-domain)
kubernetes · Sep 6, 2023 · 3276aa7 · 3276aa7
2 parents ccbd6cf + 431a296
commit 3276aa7
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/deploy/addons/registry/registry-proxy.yaml.tmpl b/deploy/addons/registry/registry-proxy.yaml.tmpl
@@ -28,6 +28,6 @@ spec:
           hostPort: 5000
         env:
         - name: REGISTRY_HOST
-          value: registry.kube-system.svc.cluster.local
+          value: registry.kube-system.svc.{{.NetworkInfo.DNSDomain}}
         - name: REGISTRY_PORT
           value: "80"
diff --git a/pkg/minikube/assets/addons.go b/pkg/minikube/assets/addons.go
@@ -935,6 +935,7 @@ func GenerateTemplateData(addon *Addon, cc *config.ClusterConfig, netInfo Networ
 	// Network info for generating template
 	opts.NetworkInfo["ControlPlaneNodeIP"] = netInfo.ControlPlaneNodeIP
 	opts.NetworkInfo["ControlPlaneNodePort"] = fmt.Sprint(netInfo.ControlPlaneNodePort)
+	opts.NetworkInfo["DNSDomain"] = cfg.DNSDomain
 
 	// Append postfix "/" to registries
 	for k, v := range opts.Registries {