chore: Improve benchmarks #2545
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
|
This issue is currently awaiting triage. If kube-state-metrics contributors determine this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
size/S
Without this change Info logs appear in the benchmark ok k8s.io/kube-state-metrics/v2/pkg/allowdenylist 0.005s I1106 08:50:22.006480 144965 builder.go:280] "Active resources" activeStoreNames="certificatesigningrequests,configmaps,cronjobs,daemonsets,deployments,endpoints,horizontalpodautoscalers,ingresses,jobs,leases,limitranges,mutatingwebhookconfigurations,namespaces,networkpolicies,nodes,persistentvolumeclaims,persistentvolumes,poddisruptionbudgets,pods,replicasets,replicationcontrollers,resourcequotas,secrets,services,statefulsets,storageclasses,validatingwebhookconfigurations,volumeattachments" goos: linux goarch: amd64 pkg: k8s.io/kube-state-metrics/v2/pkg/app cpu: Intel(R) Core(TM) i7-1065G7 CPU @ 1.30GHz BenchmarkKubeStateMetrics/GenerateMetrics-8 1 1001291639 ns/op 67578008 B/op 582810 allocs/op
k8s-ci-robot
added
size/M
k8s-ci-robot
added
the
do-not-merge/invalid-commit-message
k8s-ci-robot
removed
the
do-not-merge/invalid-commit-message
mrueg
force-pushed
the
fix-benchmarks
branch
2 times, most recently
from
f69db17 to
49ea969
Compare
The code comes from ivanvc in etcd-io/bbolt#750
|
https://github.com/kubernetes/kube-state-metrics/actions/runs/11700777818/attempts/1#summary-32585471110 this hopefully makes it easier to consume the benchmarks. |
Co-authored-by: Pranshu Srivastava <[email protected]>
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CatherineF-dev, mrueg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Oh, forgot to add "/hold" to wait others to review |
What this PR does / why we need it:
Allows to set number of rounds the benchmark should run and removes log output from it as well.
As the e2e tests take roughly twice the time of the benchmark, we can set it to two rounds (which is still better than running it only once).
How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)
None
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #